You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/08/06 14:10:43 UTC

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1422: ZOOKEEPER-3905 Race condition causes sessions to be created for clients even though their certificate authentication has failed

eolivelli commented on a change in pull request #1422:
URL: https://github.com/apache/zookeeper/pull/1422#discussion_r466440790



##########
File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientSSLTest.java
##########
@@ -156,4 +161,26 @@ public void testSecureStandaloneServer() throws Exception {
         mt.shutdown();
     }
 
+    @Test
+    public void testSecureStandaloneServerAuthFail() throws IOException {
+        try {
+            System.setProperty(ProviderRegistry.AUTHPROVIDER_PROPERTY_PREFIX + "authfail",
+                "org.apache.zookeeper.test.AuthFailX509AuthenticationProvider");

Review comment:
       nit:
   you can use `AuthFailX509AuthenticationProvider.class.getName()`
   this way this code won't be subject to problems in case of refactor/move class/rename class




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org