You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Julian Hyde <jh...@apache.org> on 2016/01/10 08:26:07 UTC

Build error in master branch

Master branch is currently broken.

Calcite does not have a public regression test, but see, for example,
the recent build errors of Travis against julianhyde/master:
https://travis-ci.org/julianhyde/calcite/builds

Vladimir, I think it is caused by your change
https://github.com/apache/calcite/commit/08647e71ef31ed13beca904273f6cf3bc6e41199.
Can you please take a look?

By the way, Can you confirm that you intended to check in VagrantFile
as part of that change?

Julian

Re: Build error in master branch

Posted by Julian Hyde <jh...@apache.org>.
Done - https://github.com/apache/calcite/commit/4a29b3ccf64e9a7d1534f540fd7f6d3d813605a0
no longer includes VagrantFile.

(Nice so see that Apache has re-enabled force-pushes to master. With
great power comes great responsibility!)

Julian


On Sun, Jan 10, 2016 at 12:40 AM, Vladimir Sitnikov
<si...@gmail.com> wrote:
> Definitely I was not.
>
> I would rebase -i that if you do not mind.
>
> Vladimir

Re: Build error in master branch

Posted by Vladimir Sitnikov <si...@gmail.com>.
Definitely I was not.

I would rebase -i that if you do not mind.

Vladimir

Re: Build error in master branch

Posted by Julian Hyde <jh...@apache.org>.
Thanks for the prompt fix -- testing it now.

Let me re-phrase the question: Did you intend to commit a VagrantFile?
See here: https://github.com/apache/calcite/blob/master/1/Vagrantfile

Julian


On Sun, Jan 10, 2016 at 12:25 AM, Vladimir Sitnikov
<si...@gmail.com> wrote:
> Here's the fix:
> https://github.com/apache/calcite/commit/b37384c8853d005f56d0ec95810cb69b425def7b
>
> Vladimir

Re: Build error in master branch

Posted by Vladimir Sitnikov <si...@gmail.com>.
Here's the fix:
https://github.com/apache/calcite/commit/b37384c8853d005f56d0ec95810cb69b425def7b

Vladimir

Re: Build error in master branch

Posted by Vladimir Sitnikov <si...@gmail.com>.
By the way: "check in VagrantFile" does not mean "run calcite tests
inside the VM", does it?
Vagrant box is used to provision databases, and the test is still
launched from the host system.
Vladimir

Re: Build error in master branch

Posted by Vladimir Sitnikov <si...@gmail.com>.
Frankly speaking, I did not mean to run a full check as the change was
trivial: new method added, old one refactored for code reuse.
It is not that good that we hit javac bug.

By the way, can we have Apache CI instance?
Vladimir