[jira] Commented: (HDFS-1496) TestStorageRestore is failing after HDFS-903 fix

["Hairong Kuang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979699#action_12979699 ] 

Hairong Kuang commented on HDFS-1496:
-------------------------------------

I do not think that the storage directory restoration scheme introduced in HADOOP-4885 works well because it introduces inconsistent states among fsimage/edits directories. Each old good directory contains old image + old edit, but each restored directory contains new image with an empty edit log. This has the potential to corrupt fsimage if secondary NN happens to download the empty edit log from a newly restored edit log directory.

I could not figure out a better way to fix this problem. Is it OK that I disable this feature for now so that unit test could pass? Good that Dhruba already enhanced saveNameSpace in HDFS-1509 that could be used as an alternative to restore the failed image directories.

> TestStorageRestore is failing after HDFS-903 fix
> ------------------------------------------------
>
>                 Key: HDFS-1496
>                 URL: https://issues.apache.org/jira/browse/HDFS-1496
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.22.0, 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Hairong Kuang
>            Priority: Blocker
>             Fix For: 0.22.0
>
>
> TestStorageRestore seems to be failing after HDFS-903 commit. Running git bisect confirms it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.