You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/04/15 19:11:51 UTC
[GitHub] [beam] kennknowles commented on a change in pull request #14528: Improvements to build_release_candidate.sh to build from tag with shallow clone
kennknowles commented on a change in pull request #14528:
URL: https://github.com/apache/beam/pull/14528#discussion_r614326907
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -175,10 +237,9 @@ if [[ $confirmation = "y" ]]; then
cd "${LOCAL_PYTHON_STAGING_DIR}"
echo '-------------------Cloning Beam Release Branch-----------------'
- git clone "${GIT_REPO_URL}"
+ git clone --branch "${RC_TAG}" --depth 1 "${GIT_REPO_URL}"
cd "${BEAM_ROOT_DIR}"
- git checkout "${RELEASE_BRANCH}"
- RELEASE_COMMIT=$(git rev-parse --verify HEAD)
+ RELEASE_COMMIT=$(git rev-list -n 1 "tags/${RC_TAG}")
Review comment:
This particular line works whether or not the RC tag is part of the release branch, so I would keep it either way.
But your question is still legit. The background is:
- [dev@ thread](https://lists.apache.org/thread.html/205472bdaf3c2c5876533750d417c19b0d1078131a3dc04916082ce8%40%3Cdev.beam.apache.org%3E) discussing ideal git release branch/RC configuration
- [new branch cut instructions](https://beam.apache.org/contribute/release-guide/#4-create-a-release-branch-in-apachebeam-repository) with diagram of end state and alterations to support script in #14239 (TL;DR remain on SNAPSHOT/dev version on release branch, advance the version on master branch)
- [new RC tagging instructions](https://beam.apache.org/contribute/release-guide/#tag-a-chosen-commit-for-the-rc) with diagram of end state and support script in #14213 (TL;DR a single tagged commit off the release branch that removes SNAPSHOT/dev, instead of the same commit that is immediately reverted)
- removal of RC tagging from building RC in #14512
And this PR is basically just bugfixes so that the script works with the new setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org