You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by dr...@apache.org on 2018/09/20 09:01:53 UTC
incubator-unomi git commit: UNOMI-189 : Fixed onpage handler
Repository: incubator-unomi
Updated Branches:
refs/heads/master 7c2372568 -> 93576d14f
UNOMI-189 : Fixed onpage handler
Project: http://git-wip-us.apache.org/repos/asf/incubator-unomi/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-unomi/commit/93576d14
Tree: http://git-wip-us.apache.org/repos/asf/incubator-unomi/tree/93576d14
Diff: http://git-wip-us.apache.org/repos/asf/incubator-unomi/diff/93576d14
Branch: refs/heads/master
Commit: 93576d14f094281036e3d293a654bdb30ac5dcf0
Parents: 7c23725
Author: tdraier <dr...@apache.org>
Authored: Thu Sep 20 11:01:48 2018 +0200
Committer: tdraier <dr...@apache.org>
Committed: Thu Sep 20 11:01:48 2018 +0200
----------------------------------------------------------------------
.../src/main/javascript/analytics.js-integration-apache-unomi.js | 4 ++--
extensions/web-tracker/wab/src/main/webapp/index.html | 4 +---
.../web-tracker/wab/src/main/webapp/javascript/unomi-tracker.js | 4 ++--
3 files changed, 5 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-unomi/blob/93576d14/extensions/web-tracker/wab/src/main/javascript/analytics.js-integration-apache-unomi.js
----------------------------------------------------------------------
diff --git a/extensions/web-tracker/wab/src/main/javascript/analytics.js-integration-apache-unomi.js b/extensions/web-tracker/wab/src/main/javascript/analytics.js-integration-apache-unomi.js
index de0bd4e..dbd3ea5 100644
--- a/extensions/web-tracker/wab/src/main/javascript/analytics.js-integration-apache-unomi.js
+++ b/extensions/web-tracker/wab/src/main/javascript/analytics.js-integration-apache-unomi.js
@@ -105,8 +105,8 @@ Unomi.prototype.onpage = function(page) {
console.log('onpage');
console.log(page);
- var unomiPage = {};
- this.fillPageData(unomiPage, props);
+ var unomiPage = { pageInfo:{} };
+ this.fillPageData(unomiPage, page.json().properties);
console.log(unomiPage);
this.collectEvent(this.buildEvent('view', this.buildPage(unomiPage), this.buildSource(this.options.scope, 'site')));
http://git-wip-us.apache.org/repos/asf/incubator-unomi/blob/93576d14/extensions/web-tracker/wab/src/main/webapp/index.html
----------------------------------------------------------------------
diff --git a/extensions/web-tracker/wab/src/main/webapp/index.html b/extensions/web-tracker/wab/src/main/webapp/index.html
index 535bb53..52bb8ee 100644
--- a/extensions/web-tracker/wab/src/main/webapp/index.html
+++ b/extensions/web-tracker/wab/src/main/webapp/index.html
@@ -28,8 +28,7 @@
window.unomiTracker || (window.unomiTracker = {});
window.unomiTracker_queue || (window.unomiTracker_queue = []);
(function() {
- var methods = ['trackSubmit', 'trackClick', 'trackLink', 'trackForm', 'initialize', 'pageview', 'identify', 'reset', 'group',
- 'track', 'ready', 'alias', 'debug', 'page', 'once', 'off', 'on'];
+ var methods = ['trackSubmit', 'trackClick', 'trackLink', 'trackForm', 'initialize', 'pageview', 'identify', 'reset', 'group', 'track', 'ready', 'alias', 'debug', 'page', 'once', 'off', 'on'];
var factory = function(method) {
return function () {
@@ -50,7 +49,6 @@
// Define a method to load Analytics.js from our CDN,
// and that will be sure to only ever load it once.
unomiTracker.load = function(callback, option) {
- console.log('load');
// Create an async script element based on your key.
var script = document.createElement('script');
script.type = 'text/javascript';
http://git-wip-us.apache.org/repos/asf/incubator-unomi/blob/93576d14/extensions/web-tracker/wab/src/main/webapp/javascript/unomi-tracker.js
----------------------------------------------------------------------
diff --git a/extensions/web-tracker/wab/src/main/webapp/javascript/unomi-tracker.js b/extensions/web-tracker/wab/src/main/webapp/javascript/unomi-tracker.js
index 40b5f64..e264b03 100644
--- a/extensions/web-tracker/wab/src/main/webapp/javascript/unomi-tracker.js
+++ b/extensions/web-tracker/wab/src/main/webapp/javascript/unomi-tracker.js
@@ -12648,8 +12648,8 @@ Unomi.prototype.onpage = function(page) {
console.log('onpage');
console.log(page);
- var unomiPage = {};
- this.fillPageData(unomiPage, props);
+ var unomiPage = { pageInfo:{} };
+ this.fillPageData(unomiPage, page.json().properties);
console.log(unomiPage);
this.collectEvent(this.buildEvent('view', this.buildPage(unomiPage), this.buildSource(this.options.scope, 'site')));