You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/11/16 18:35:52 UTC
Re: [PR] [CELEBORN-1131] Adds support for Sasl Authentication in Celeborn's Transport layer [incubator-celeborn]
codecov[bot] commented on PR #2105:
URL: https://github.com/apache/incubator-celeborn/pull/2105#issuecomment-1815018801
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `114 lines` in your changes are missing coverage. Please review.
> :exclamation: No coverage uploaded for pull request base (`main@02cea04`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit).
> Report is 10 commits behind head on main.
| [Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/celeborn/common/network/sasl/SaslRpcHandler.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zYXNsL1Nhc2xScGNIYW5kbGVyLmphdmE=) | 66.67% | [11 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...leborn/common/network/sasl/CelebornSaslClient.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zYXNsL0NlbGVib3JuU2FzbENsaWVudC5qYXZh) | 66.67% | [11 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...leborn/common/network/sasl/CelebornSaslServer.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zYXNsL0NlbGVib3JuU2FzbFNlcnZlci5qYXZh) | 80.33% | [6 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ork/sasl/anonymous/AnonymousSaslClientFactory.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zYXNsL2Fub255bW91cy9Bbm9ueW1vdXNTYXNsQ2xpZW50RmFjdG9yeS5qYXZh) | 47.37% | [7 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ork/sasl/anonymous/AnonymousSaslServerFactory.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zYXNsL2Fub255bW91cy9Bbm9ueW1vdXNTYXNsU2VydmVyRmFjdG9yeS5qYXZh) | 44.45% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...eborn/common/network/sasl/SaslClientBootstrap.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zYXNsL1Nhc2xDbGllbnRCb290c3RyYXAuamF2YQ==) | 77.15% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/celeborn/common/rpc/netty/NettyRpcEnv.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3JwYy9uZXR0eS9OZXR0eVJwY0Vudi5zY2FsYQ==) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...common/network/server/TransportRequestHandler.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvVHJhbnNwb3J0UmVxdWVzdEhhbmRsZXIuamF2YQ==) | 76.67% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...born/common/network/sasl/SaslTimeoutException.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zYXNsL1Nhc2xUaW1lb3V0RXhjZXB0aW9uLmphdmE=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../common/network/client/TransportClientFactory.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0Q2xpZW50RmFjdG9yeS5qYXZh) | 73.69% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [6 more](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2105 +/- ##
=======================================
Coverage ? 47.58%
=======================================
Files ? 180
Lines ? 11056
Branches ? 1005
=======================================
Hits ? 5260
Misses ? 5445
Partials ? 351
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2105?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org