[GitHub] [netbeans] neilcsmith-net commented on pull request #2232: [NETBEANS-4699] Make it easy to create dynamically updated ProxyLookup instances without subclassing

[GitBox <gi...@apache.org>]

neilcsmith-net commented on pull request #2232:
URL: https://github.com/apache/netbeans/pull/2232#issuecomment-671039920


   Thanks, although I didn't say we needed a JIRA ticket, just that if there's an issue link it needs to go there.  Have added to title, which may or may not link things up - it's meant to sync.
   
   Do we really need this in 12.1?  I'm trying to get last PRs synced for final beta over next couple of days.  We're in feature freeze, but not against this if it's problem free!  It needs squashing and force pushing here before merging though (GitHub squash and merge is problematic).
   
   Is the API documentation correct? 
   
   > if called before that ProxyLookup has been created, the lookup contents will be set during that ProxyLookup's constructor as if you had passed them to the constructor directly.
   
   Am I missing something?  Doesn't it throw an IllegalStateException in that scenario?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists