You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "RoyLee1224 (via GitHub)" <gi...@apache.org> on 2025/09/11 17:05:09 UTC
[I] Implement FilterBar component for Asset Events and Audit logs [airflow]
RoyLee1224 opened a new issue, #55520:
URL: https://github.com/apache/airflow/issues/55520
### Description
The implementation for Asset Events(#54640 ) and Audit logs(#54210) filters is complete. The next step is to use FilterBar component.
TO-DO
- [ ] Asset Events
- [ ] Audit logs
### Use case/motivation
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [x] Yes I am willing to submit a PR!
### Code of Conduct
- [x] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3285973828
Thanks @RoyLee1224 for the context and clarity
@BrianLii if you’re already moving on this, happy for you to lead. Would it work if you own the Asset Events → FilterBar swap, and I take Audit Logs + the DAG Run Tasks tab in parallel? I’m also open to any split you prefer—please let me know and I’ll follow your lead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3285836695
Great to see interest from both @BrianLii and @KatalKavya96!
Just for context, I'm a contributor here, not a committer. I initially tagged @BrianLii because he recently completed the first part of the asset event filter, and this seemed like a natural next step for him.
I'll leave it to you all to discuss how to divide the tasks.
Feel free to ping me if you run into any blockers while implementing, I'm happy to help.💪
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3303415295
@RoyLee1224 Please look at what current implementation looks like from my side and Please suggest further improvements and changes
https://github.com/user-attachments/assets/976a84fe-1b6f-4c45-acd6-d0e22ab64c7b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3301726863
@RoyLee1224 After fixing the internal server error i still get no dags on UI, It shows No Dag Found, There is no error in fetching this time. Please suggest steps to get sample/mock dags to test in UI. Also conversation here is getting too big ,Please suggest an alternative place for communication and queries which you would prefer. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "BrianLii (via GitHub)" <gi...@apache.org>.
BrianLii commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3286329494
Hi @KatalKavya96, that works for me. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3986437024
@KatalKavya96 We are unassigning you from this issue as part of our updated [assignment policy](https://github.com/apache/airflow/blob/main/contributing-docs/04_how_to_contribute.rst#contribute-code-changes).
This is not meant to discourage your contribution — quite the opposite! You are still very welcome to work on this issue and submit a PR for it. Simply comment that you are working on it and open a PR when ready.
We found that formal assignments were not working well, as they often prevented others from contributing when the assignee was not actively working on the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3304726329
@RoyLee1224 Do i also have to write tests for the changed UI or can i raise PR directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "BrianLii (via GitHub)" <gi...@apache.org>.
BrianLii commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3287675818
I think opening two small PRs works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3281951732
@BrianLii If you're interested in taking over from here, feel free to pick it up. We can discuss the implementation details right here.
No worries if you don't have the time right now, I can go ahead and finish it. Just let me know what you think! 💪
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "BrianLii (via GitHub)" <gi...@apache.org>.
BrianLii commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3285734714
Hi @RoyLee1224, I can work on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3303950508
Nice, overall looks good. You can now use the new select-type filter (see #55620). Just open a PR when you're ready, and we can all jump in on the code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3986437308
@BrianLii We are unassigning you from this issue as part of our updated [assignment policy](https://github.com/apache/airflow/blob/main/contributing-docs/04_how_to_contribute.rst#contribute-code-changes).
This is not meant to discourage your contribution — quite the opposite! You are still very welcome to work on this issue and submit a PR for it. Simply comment that you are working on it and open a PR when ready.
We found that formal assignments were not working well, as they often prevented others from contributing when the assignee was not actively working on the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi closed issue #55520: Implement FilterBar component for Asset Events and Audit logs
URL: https://github.com/apache/airflow/issues/55520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3288810062
Hello @RoyLee1224 Can you please guide me once what exactly are we expecting in UI for Audit logs and Tasks in dagrun detail page .Once clarified i shall start creating it , Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3309493553
@RoyLee1224 I have removed unnecessary changes from the PR . Please review it once. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3297957854
@RoyLee1224 I am getting this error 500 Internal Server Error in fetching dags which is causing me trouble testing UI, Please look into this and suggest next steps to get it correct
<img width="1345" height="652" alt="Image" src="https://github.com/user-attachments/assets/aadd3b08-f342-4c6f-80c3-6ba70878b89e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3284882028
@RoyLee1224 Hello , I would like to work on this issue. My Airflow dev setup is ready, Please assign this issue to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3299144164
That's because we got some changes in schema.
I think `breeze down` and restart the Breeze environment would solve the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3286626909
@BrianLii @RoyLee1224 Thanks! What is the preferred workflow here
- keep #55520 as the parent and open two small PRs (Audit Logs, DAG Run → Tasks) linked to it, or
- raise two follow-up issues and PRs for each?
I am happy to follow project convention. I can start with Audit Logs right away once you confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "BrianLii (via GitHub)" <gi...@apache.org>.
BrianLii commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3289871865
The `FilterBar` has been integrated into AssetEventsFilters in #55522. I believe the Asset Events part can now be considered complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3289850202
Hi @RoyLee1224 — I have opened a PR that migrates the DAG Run → Task Instances tab to the new FilterBar (pill) UI. It is scoped to just this tab for now. Could you review and share any changes or cleanups you would like? I will apply the same pattern to the remaining DAG Run sections in follow up commits once this looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3293209115
@BrianLii, my apologies! I hadn't seen that when I wrote my previous comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3288973430
@KatalKavya96
For current filters implementation, you can check #54484 for task and #54210 for audit log.
What we need to do is “changing them into using filterBar component”, just like what we did in Xcom page(#54895)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3287971014
@BrianLii thanks! I’m going to open a separate PR for this work (rather than a new issue).
To make sure my PR lines up with what’s already landed, could you share a quick status per section—what’s done vs. what’s still pending
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3302872150
Have you placed your Dag files in the correct dags folder(`files/dags`)? If you need some to test with, you can use example Dags here: https://github.com/apache/airflow/tree/main/airflow/example_dags
If the Dags are in the folder but not appearing, you can force Airflow to re-parse them by running `airflow dags reserialize`
Regarding communication, I'm happy to continue our discussion here. However, if you want to ask troubleshooting questions somewhere else, you can try Airflow Slack channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3304751978
Just open one,so we can make sure what we need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-3304796814
@RoyLee1224 I have raised the Pull Request, please look into it and suggest any further changes if required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Implement FilterBar component for Asset Events and Audit logs [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on issue #55520:
URL: https://github.com/apache/airflow/issues/55520#issuecomment-4973314385
Filters have been added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org