You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/07/10 23:55:41 UTC
[kudu-CR] [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13841
Change subject: [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)
......................................................................
[doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)
Since both {KuduScanner,KuduScanTokenBuilder}::SetDiffScan() are both
under the same PRIVATE_API conditional, it's possible to use the
@copydoc to avoid the duplication of the description.
This is a follow-up to 0b4948ea3.
Change-Id: I2de45bf62bd8ef240b0d0e0cd3f887ef3d40cd04
---
M src/kudu/client/client.h
1 file changed, 1 insertion(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/13841/1
--
To view, visit http://gerrit.cloudera.org:8080/13841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2de45bf62bd8ef240b0d0e0cd3f887ef3d40cd04
Gerrit-Change-Number: 13841
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13841 )
Change subject: [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)
......................................................................
[doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)
Since both {KuduScanner,KuduScanTokenBuilder}::SetDiffScan() are both
under the same PRIVATE_API conditional, it's possible to use the
@copydoc to avoid the duplication of the description.
This is a follow-up to 0b4948ea3.
Change-Id: I2de45bf62bd8ef240b0d0e0cd3f887ef3d40cd04
Reviewed-on: http://gerrit.cloudera.org:8080/13841
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/client/client.h
1 file changed, 1 insertion(+), 16 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2de45bf62bd8ef240b0d0e0cd3f887ef3d40cd04
Gerrit-Change-Number: 13841
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13841 )
Change subject: [doxygen] fix KuduScanTokenBuilder::SetDiffScan (take two)
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2de45bf62bd8ef240b0d0e0cd3f887ef3d40cd04
Gerrit-Change-Number: 13841
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Jul 2019 01:06:48 +0000
Gerrit-HasComments: No