You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/18 01:55:39 UTC

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

graceguo-supercat opened a new pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829

### SUMMARY
This PR is to fix 2 issues in **single value** filter_box.

### BEFORE

1. Clear filter_box won't clear filter's default value
![gGtwLBI2qw](https://user-images.githubusercontent.com/27990562/82166530-9365c900-986d-11ea-89a6-c60e68c8ab32.gif)

1. Set default value for a single value filter_box, the column's data type is FLOAT:
<img width="570" alt="Screen Shot 2020-05-17 at 6 48 57 PM" src="https://user-images.githubusercontent.com/27990562/82167010-34a14f00-986f-11ea-9a14-1516e9939aea.png">
In dashboard, this string value doesn't match with filter's data type, so that it looks the same option show twice:
<img width="760" alt="Screen Shot 2020-05-17 at 6 50 46 PM" src="https://user-images.githubusercontent.com/27990562/82167070-6d412880-986f-11ea-8b5f-21e83cb0cf8b.png">

Proposed solution:

1. When user clear filter_box, the option value should be null. While when filter_box value is undefined, should use defaultValue.
2. When user update defaultValue for filter_box, add type cast for numeric and boolean type column.

### TEST PLAN
CI and manual test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

ktmud commented on a change in pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#discussion_r426824394



##########
File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx
##########
@@ -27,6 +27,9 @@ import SelectControl from './SelectControl';
 import CheckboxControl from './CheckboxControl';
 import TextControl from './TextControl';
 
+const INTEGRAL_TYPES = ['TINYINT', 'SMALLINT', 'INT', 'INTEGER', 'BIGINT'];
+const DECIMAL_TYPES = ['FLOAT', 'DOUBLE'];

Review comment:
       Can we use `Set`? It's faster than arrays.
   
   ```
   const DECIMAL_TYPES = new Set(['FLOAT', 'DOUBLE'])
   
   DECIMAL_TYPES.has(columnType)
   ```
   
   Not sure what types are returned to the frontend, but are we sure these types are exhaustive: https://github.com/apache/incubator-superset/blob/a6cedaaa879348aca49a520793bb20e63d152a1f/superset/connectors/base/models.py#L480-L493
   
   Might want to add `LONG` to `INTEGRAL_TYPES`; and `NUMERIC`, `NUMBER`, `REAL` and `DECIMAL` to `DECIMAL_TYPES`, too?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

graceguo-supercat commented on a change in pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#discussion_r426931499



##########
File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx
##########
@@ -60,7 +63,35 @@ export default class FilterBoxItemControl extends React.Component {
     this.props.onChange(this.state);
   }
   onControlChange(attr, value) {
-    this.setState({ [attr]: value }, this.onChange);
+    let typedValue = value;
+    const { column: selectedColumnName, multiple } = this.state;
+    if (value && !multiple && attr === 'defaultValue') {

Review comment:
       added 2 constants, `defaultValue` and `multi` (used by this feature). but there are quite a few other attributes used in many places...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

ktmud commented on pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-630374097


   LGTM, just a couple of style nits.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

graceguo-supercat commented on a change in pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#discussion_r426931499



##########
File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx
##########
@@ -60,7 +63,35 @@ export default class FilterBoxItemControl extends React.Component {
     this.props.onChange(this.state);
   }
   onControlChange(attr, value) {
-    this.setState({ [attr]: value }, this.onChange);
+    let typedValue = value;
+    const { column: selectedColumnName, multiple } = this.state;
+    if (value && !multiple && attr === 'defaultValue') {

Review comment:
       added 2 constants, `defaultValue` and `multiple` (used by this feature). but there are quite a few other attributes used in many places...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=h1) Report
   > Merging [#9829](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea9b7f2dc426cf912f8f5f2b749cc707c9af6964&el=desc) will **increase** coverage by `0.08%`.
   > The diff coverage is `13.04%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9829/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9829      +/-   ##
   ==========================================
   + Coverage   66.16%   66.25%   +0.08%     
   ==========================================
     Files         585      586       +1     
     Lines       30427    30655     +228     
     Branches     3152     3165      +13     
   ==========================================
   + Hits        20133    20310     +177     
   - Misses      10113    10164      +51     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.16% <13.04%> (-0.10%)` | :arrow_down: |
   | #python | `71.20% <ø> (+0.17%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.08% <0.00%> (ø)` | |
   | [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `45.61% <9.52%> (-19.26%)` | :arrow_down: |
   | [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckNvbmZpZ3NGcm9tRm9ybWRhdGEuanM=) | `88.46% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.25% <0.00%> (-0.89%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <0.00%> (ø)` | |
   | [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `11.62% <0.00%> (ø)` | |
   | [...set-frontend/src/dashboard/util/downloadAsImage.ts](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Rvd25sb2FkQXNJbWFnZS50cw==) | `44.44% <0.00%> (ø)` | |
   | ... and [31 more](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=footer). Last update [ea9b7f2...bdabbe2](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=h1) Report
   > Merging [#9829](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea9b7f2dc426cf912f8f5f2b749cc707c9af6964&el=desc) will **increase** coverage by `4.62%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9829/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9829      +/-   ##
   ==========================================
   + Coverage   66.16%   70.79%   +4.62%     
   ==========================================
     Files         585      184     -401     
     Lines       30427    17868   -12559     
     Branches     3152        0    -3152     
   ==========================================
   - Hits        20133    12649    -7484     
   + Misses      10113     5219    -4894     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `70.79% <ø> (-0.24%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.77% <0.00%> (-2.36%)` | :arrow_down: |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <0.00%> (-1.03%)` | :arrow_down: |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.62% <0.00%> (-0.35%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: |
   | ... and [399 more](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=footer). Last update [ea9b7f2...bdabbe2](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

etr2460 commented on a change in pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#discussion_r426852348



##########
File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx
##########
@@ -60,7 +63,35 @@ export default class FilterBoxItemControl extends React.Component {
     this.props.onChange(this.state);
   }
   onControlChange(attr, value) {
-    this.setState({ [attr]: value }, this.onChange);
+    let typedValue = value;
+    const { column: selectedColumnName, multiple } = this.state;
+    if (value && !multiple && attr === 'defaultValue') {

Review comment:
       should `defaultValue` be a string constant somewhere that's used here and in the filter config?

##########
File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx
##########
@@ -60,7 +63,35 @@ export default class FilterBoxItemControl extends React.Component {
     this.props.onChange(this.state);
   }
   onControlChange(attr, value) {
-    this.setState({ [attr]: value }, this.onChange);
+    let typedValue = value;
+    const { column: selectedColumnName, multiple } = this.state;
+    if (value && !multiple && attr === 'defaultValue') {
+      // if single value filter_box,
+      // convert input value string to the column's data type
+      const { datasource } = this.props;
+      const selectedColumn = (
+        datasource.columns.filter(
+          col => col.column_name === selectedColumnName,
+        ) || []
+      ).pop();
+
+      if (selectedColumn && selectedColumn.type) {
+        const type = selectedColumn.type.toUpperCase();
+        try {
+          if (type === 'BOOLEAN') {
+            typedValue = value === 'true';
+          } else if (INTEGRAL_TYPES.includes(type)) {
+            typedValue = parseInt(value, 10);
+          } else if (DECIMAL_TYPES.includes(type)) {
+            typedValue = parseFloat(value);
+          }
+        } catch (ex) {

Review comment:
       when does this fail? I don't think `parseInt` or `parseFloat` throw errors with invalid input. instead they return `NaN`. I think we can remove the try/catch block




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=h1) Report
   > Merging [#9829](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea9b7f2dc426cf912f8f5f2b749cc707c9af6964&el=desc) will **increase** coverage by `4.84%`.
   > The diff coverage is `73.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9829/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9829      +/-   ##
   ==========================================
   + Coverage   66.16%   71.01%   +4.84%     
   ==========================================
     Files         585      583       -2     
     Lines       30427    30634     +207     
     Branches     3152     3165      +13     
   ==========================================
   + Hits        20133    21755    +1622     
   + Misses      10113     8766    -1347     
   + Partials      181      113      -68     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.55% <26.66%> (?)` | |
   | #javascript | `59.31% <66.66%> (+0.05%)` | :arrow_up: |
   | #python | `71.27% <ø> (+0.24%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `74.16% <33.33%> (+69.08%)` | :arrow_up: |
   | [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `75.47% <78.94%> (+10.60%)` | :arrow_up: |
   | [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckNvbmZpZ3NGcm9tRm9ybWRhdGEuanM=) | `89.28% <100.00%> (+0.82%)` | :arrow_up: |
   | [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <100.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <0.00%> (ø)` | |
   | [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `98.07% <0.00%> (ø)` | |
   | [...frontend/src/components/ListView/LegacyFilters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGVnYWN5RmlsdGVycy50c3g=) | `75.00% <0.00%> (ø)` | |
   | [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
   | ... and [178 more](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=footer). Last update [ea9b7f2...183f980](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=h1) Report
   > Merging [#9829](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea9b7f2dc426cf912f8f5f2b749cc707c9af6964&el=desc) will **decrease** coverage by `6.84%`.
   > The diff coverage is `80.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9829/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9829      +/-   ##
   ==========================================
   - Coverage   66.16%   59.31%   -6.85%     
   ==========================================
     Files         585      399     -186     
     Lines       30427    12581   -17846     
     Branches     3152     3163      +11     
   ==========================================
   - Hits        20133     7463   -12670     
   + Misses      10113     4937    -5176     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.31% <80.00%> (+0.06%)` | :arrow_up: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.08% <0.00%> (ø)` | |
   | [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `75.47% <78.94%> (+10.60%)` | :arrow_up: |
   | [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckNvbmZpZ3NGcm9tRm9ybWRhdGEuanM=) | `89.28% <100.00%> (+0.82%)` | :arrow_up: |
   | [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <100.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `49.07% <0.00%> (ø)` | |
   | [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `76.78% <0.00%> (ø)` | |
   | [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `98.07% <0.00%> (ø)` | |
   | [...frontend/src/components/ListView/LegacyFilters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGVnYWN5RmlsdGVycy50c3g=) | `75.00% <0.00%> (ø)` | |
   | [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `13.23% <0.00%> (ø)` | |
   | ... and [192 more](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=footer). Last update [ea9b7f2...183f980](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=h1) Report
   > Merging [#9829](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea9b7f2dc426cf912f8f5f2b749cc707c9af6964&el=desc) will **increase** coverage by `4.80%`.
   > The diff coverage is `73.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9829/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9829      +/-   ##
   ==========================================
   + Coverage   66.16%   70.97%   +4.80%     
   ==========================================
     Files         585      583       -2     
     Lines       30427    30634     +207     
     Branches     3152     3165      +13     
   ==========================================
   + Hits        20133    21743    +1610     
   + Misses      10113     8778    -1335     
   + Partials      181      113      -68     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.55% <26.66%> (?)` | |
   | #javascript | `59.31% <66.66%> (+0.05%)` | :arrow_up: |
   | #python | `71.20% <ø> (+0.17%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `74.16% <33.33%> (+69.08%)` | :arrow_up: |
   | [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `75.47% <78.94%> (+10.60%)` | :arrow_up: |
   | [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckNvbmZpZ3NGcm9tRm9ybWRhdGEuanM=) | `89.28% <100.00%> (+0.82%)` | :arrow_up: |
   | [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.25% <0.00%> (-0.89%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <0.00%> (ø)` | |
   | [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `98.07% <0.00%> (ø)` | |
   | ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=footer). Last update [ea9b7f2...183f980](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=h1) Report
   > Merging [#9829](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea9b7f2dc426cf912f8f5f2b749cc707c9af6964&el=desc) will **increase** coverage by `5.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9829/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9829      +/-   ##
   ==========================================
   + Coverage   66.16%   71.20%   +5.03%     
   ==========================================
     Files         585      184     -401     
     Lines       30427    18051   -12376     
     Branches     3152        0    -3152     
   ==========================================
   - Hits        20133    12853    -7280     
   + Misses      10113     5198    -4915     
   + Partials      181        0     -181     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `71.20% <ø> (+0.17%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.25% <0.00%> (-0.89%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/components/CheckboxIcons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy5qc3g=) | | |
   | [...hboard/components/gridComponents/new/NewHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdIZWFkZXIuanN4) | | |
   | [...tend/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIuanN4) | | |
   | [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | | |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | | |
   | ... and [422 more](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=footer). Last update [ea9b7f2...183f980](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=h1) Report
   > Merging [#9829](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea9b7f2dc426cf912f8f5f2b749cc707c9af6964&el=desc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `13.04%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9829/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9829      +/-   ##
   ==========================================
   - Coverage   66.16%   66.07%   -0.10%     
   ==========================================
     Files         585      586       +1     
     Lines       30427    30472      +45     
     Branches     3152     3165      +13     
   ==========================================
   + Hits        20133    20135       +2     
   - Misses      10113    10156      +43     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.16% <13.04%> (-0.10%)` | :arrow_down: |
   | #python | `70.95% <ø> (-0.08%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.08% <0.00%> (ø)` | |
   | [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `45.61% <9.52%> (-19.26%)` | :arrow_down: |
   | [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckNvbmZpZ3NGcm9tRm9ybWRhdGEuanM=) | `88.46% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.25% <0.00%> (-0.89%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.91% <0.00%> (-0.10%)` | :arrow_down: |
   | [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `11.62% <0.00%> (ø)` | |
   | [...set-frontend/src/dashboard/util/downloadAsImage.ts](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Rvd25sb2FkQXNJbWFnZS50cw==) | `44.44% <0.00%> (ø)` | |
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `70.83% <0.00%> (+1.26%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=footer). Last update [ea9b7f2...bdabbe2](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=h1) Report
   > Merging [#9829](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea9b7f2dc426cf912f8f5f2b749cc707c9af6964&el=desc) will **decrease** coverage by `0.18%`.
   > The diff coverage is `13.04%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9829/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9829      +/-   ##
   ==========================================
   - Coverage   66.16%   65.98%   -0.19%     
   ==========================================
     Files         585      586       +1     
     Lines       30427    30472      +45     
     Branches     3152     3165      +13     
   ==========================================
   - Hits        20133    20106      -27     
   - Misses      10113    10185      +72     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.16% <13.04%> (-0.10%)` | :arrow_down: |
   | #python | `70.79% <ø> (-0.24%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `5.08% <0.00%> (ø)` | |
   | [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `45.61% <9.52%> (-19.26%)` | :arrow_down: |
   | [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckNvbmZpZ3NGcm9tRm9ybWRhdGEuanM=) | `88.46% <100.00%> (ø)` | |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.77% <0.00%> (-2.36%)` | :arrow_down: |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <0.00%> (-1.03%)` | :arrow_down: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=footer). Last update [ea9b7f2...bdabbe2](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] ktmud commented on a change in pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

ktmud commented on a change in pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#discussion_r426823293



##########
File path: superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx
##########
@@ -60,7 +63,35 @@ export default class FilterBoxItemControl extends React.Component {
     this.props.onChange(this.state);
   }
   onControlChange(attr, value) {
-    this.setState({ [attr]: value }, this.onChange);
+    let typedValue = value;
+    const { column: selectedColumnName, multiple } = this.state;
+    if (value && !multiple && attr === 'defaultValue') {
+      // if single value filter_box,
+      // convert input value string to the column's data type
+      const { datasource } = this.props;
+      const selectedColumn = (
+        datasource.columns.filter(
+          col => col.column_name === selectedColumnName,
+        ) || []
+      ).pop();

Review comment:
       ```js
   selectedColumn = datasource.columns.find(x => x.column_name === selectedColumnName);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=h1) Report
   > Merging [#9829](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea9b7f2dc426cf912f8f5f2b749cc707c9af6964&el=desc) will **increase** coverage by `4.80%`.
   > The diff coverage is `17.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9829/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9829      +/-   ##
   ==========================================
   + Coverage   66.16%   70.97%   +4.80%     
   ==========================================
     Files         585      586       +1     
     Lines       30427    30655     +228     
     Branches     3152     3165      +13     
   ==========================================
   + Hits        20133    21758    +1625     
   + Misses      10113     8786    -1327     
   + Partials      181      111      -70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.50% <17.39%> (?)` | |
   | #javascript | `59.16% <13.04%> (-0.10%)` | :arrow_down: |
   | #python | `71.27% <ø> (+0.24%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `45.61% <9.52%> (-19.26%)` | :arrow_down: |
   | [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckNvbmZpZ3NGcm9tRm9ybWRhdGEuanM=) | `88.46% <100.00%> (ø)` | |
   | [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `74.57% <100.00%> (+69.49%)` | :arrow_up: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <0.00%> (ø)` | |
   | [...set-frontend/src/dashboard/util/downloadAsImage.ts](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Rvd25sb2FkQXNJbWFnZS50cw==) | `44.44% <0.00%> (ø)` | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (+<0.01%)` | :arrow_up: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.95% <0.00%> (+0.01%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.02% <0.00%> (+0.02%)` | :arrow_up: |
   | ... and [172 more](https://codecov.io/gh/apache/incubator-superset/pull/9829/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=footer). Last update [ea9b7f2...bdabbe2](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat merged pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

Posted by GitBox <gi...@apache.org>.

graceguo-supercat merged pull request #9829:
URL: https://github.com/apache/incubator-superset/pull/9829


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org