You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/25 15:42:08 UTC

[GitHub] [airflow] TylerLubeck opened a new pull request, #23223: Add optional Prometheus Service Monitor

TylerLubeck opened a new pull request, #23223:
URL: https://github.com/apache/airflow/pull/23223

   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   Add a ServiceMonitor object for use with the [Prometheus Operator](https://github.com/prometheus-operator/prometheus-operator). 
   ---
   
   We've been using this with great effect internally and thought it would be useful for others as well. I've set it up to be entirely optional, as it does require the Prometheus Operator to already be installed and configured in the kube cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] TylerLubeck commented on pull request #23223: Add optional Prometheus Service Monitor

Posted by GitBox <gi...@apache.org>.

TylerLubeck commented on PR #23223:
URL: https://github.com/apache/airflow/pull/23223#issuecomment-1122462012

   Sounds good, thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #23223: Add optional Prometheus Service Monitor

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #23223:
URL: https://github.com/apache/airflow/pull/23223#issuecomment-1120495515

   I guess it can be done by using a subchart functionality https://helm.sh/docs/chart_template_guide/subcharts_and_globals/ there is no reson to add it to he community chart. You can also release your own GitHub project doing it and share it in https://airflow.apache.org/ecosystem/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23223: Add optional Prometheus Service Monitor

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on PR #23223:
URL: https://github.com/apache/airflow/pull/23223#issuecomment-1108738935

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] TylerLubeck closed pull request #23223: Add optional Prometheus Service Monitor

Posted by GitBox <gi...@apache.org>.

TylerLubeck closed pull request #23223: Add optional Prometheus Service Monitor
URL: https://github.com/apache/airflow/pull/23223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org