You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/08/20 19:32:40 UTC

[kudu-CR] [hms] Add Hcatalog jars to the HMS classpath 

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11273


Change subject: [hms] Add Hcatalog jars to the HMS classpath
......................................................................

[hms] Add Hcatalog jars to the HMS classpath

Due to the packaging differences of Hive distributions, the Hcatalog
jars may not be loaded into the classpath of mini HMS, which will cause
the ClassNotFoundException when using notification log event lisenter.
This patch explicitly added these jars.

Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
---
M src/kudu/hms/mini_hms.cc
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/11273/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Gerrit-Change-Number: 11273
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR] [hms] Add Hcatalog jars to the HMS classpath

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11273

to look at the new patch set (#2).

Change subject: [hms] Add Hcatalog jars to the HMS classpath
......................................................................

[hms] Add Hcatalog jars to the HMS classpath

Due to the packaging differences of Hive distributions, the Hcatalog
jars may not be loaded into the classpath of mini HMS, which will cause
the ClassNotFoundException when using notification log event listener.
This patch explicitly adds these jars.

Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
---
M src/kudu/hms/mini_hms.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/11273/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Gerrit-Change-Number: 11273
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [hms] Add Hcatalog jars to the HMS classpath

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11273 )

Change subject: [hms] Add Hcatalog jars to the HMS classpath
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Gerrit-Change-Number: 11273
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 19:51:47 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] Add Hcatalog jars to the HMS classpath

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11273 )

Change subject: [hms] Add Hcatalog jars to the HMS classpath
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11273/1/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

http://gerrit.cloudera.org:8080/#/c/11273/1/src/kudu/hms/mini_hms.cc@119
PS1, Line 119:   string aux_jars = Substitute("$0/hms-plugin.jar,$1/hcatalog/share/hcatalog/*", bin_dir, hive_home);
             : 
> Nit: I think it's clearer if combined:
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Gerrit-Change-Number: 11273
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 01:06:13 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] Add Hcatalog jars to the HMS classpath

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11273 )

Change subject: [hms] Add Hcatalog jars to the HMS classpath
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11273/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11273/1//COMMIT_MSG@11
PS1, Line 11: lisenter
listener


http://gerrit.cloudera.org:8080/#/c/11273/1//COMMIT_MSG@12
PS1, Line 12: added
adds


http://gerrit.cloudera.org:8080/#/c/11273/1/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

http://gerrit.cloudera.org:8080/#/c/11273/1/src/kudu/hms/mini_hms.cc@119
PS1, Line 119:   string hcatalog_jars = Substitute("$0/hcatalog/share/hcatalog/*", hive_home);
             :   string aux_jars = Substitute("$0/hms-plugin.jar,$1", bin_dir, hcatalog_jars);
Nit: I think it's clearer if combined:

  string aux_jars = Substitute("$0/hms-plugin.jar,$1/hcatalog/share/hcatalog/*", bin_dir, hive_home);

If/when the list gets longer, we should treat it as a list, set it up entry by entry, and then join it together.



-- 
To view, visit http://gerrit.cloudera.org:8080/11273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Gerrit-Change-Number: 11273
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 20 Aug 2018 19:53:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] Add Hcatalog jars to the HMS classpath

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11273 )

Change subject: [hms] Add Hcatalog jars to the HMS classpath
......................................................................

[hms] Add Hcatalog jars to the HMS classpath

Due to the packaging differences of Hive distributions, the Hcatalog
jars may not be loaded into the classpath of mini HMS, which will cause
the ClassNotFoundException when using notification log event listener.
This patch explicitly adds these jars.

Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Reviewed-on: http://gerrit.cloudera.org:8080/11273
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/hms/mini_hms.cc
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified
  Dan Burkert: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Gerrit-Change-Number: 11273
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [hms] Add Hcatalog jars to the HMS classpath

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11273 )

Change subject: [hms] Add Hcatalog jars to the HMS classpath
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11273/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11273/1//COMMIT_MSG@11
PS1, Line 11: listener
> listener
Done


http://gerrit.cloudera.org:8080/#/c/11273/1//COMMIT_MSG@12
PS1, Line 12: adds 
> adds
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Gerrit-Change-Number: 11273
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 01:06:03 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] Add Hcatalog jars to the HMS classpath

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11273 )

Change subject: [hms] Add Hcatalog jars to the HMS classpath
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11273/2/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

http://gerrit.cloudera.org:8080/#/c/11273/2/src/kudu/hms/mini_hms.cc@119
PS2, Line 119:   string aux_jars = Substitute("$0/hms-plugin.jar,$1/hcatalog/share/hcatalog/*",
> Looks like you need to wrap this to make lint happy.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Gerrit-Change-Number: 11273
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 19:48:08 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] Add Hcatalog jars to the HMS classpath

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11273 )

Change subject: [hms] Add Hcatalog jars to the HMS classpath
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Gerrit-Change-Number: 11273
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 21:23:38 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] Add Hcatalog jars to the HMS classpath

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11273 )

Change subject: [hms] Add Hcatalog jars to the HMS classpath
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11273/2/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

http://gerrit.cloudera.org:8080/#/c/11273/2/src/kudu/hms/mini_hms.cc@119
PS2, Line 119:   string aux_jars = Substitute("$0/hms-plugin.jar,$1/hcatalog/share/hcatalog/*", bin_dir, hive_home);
Looks like you need to wrap this to make lint happy.



-- 
To view, visit http://gerrit.cloudera.org:8080/11273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Gerrit-Change-Number: 11273
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 21 Aug 2018 04:08:28 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] Add Hcatalog jars to the HMS classpath

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11273

to look at the new patch set (#3).

Change subject: [hms] Add Hcatalog jars to the HMS classpath
......................................................................

[hms] Add Hcatalog jars to the HMS classpath

Due to the packaging differences of Hive distributions, the Hcatalog
jars may not be loaded into the classpath of mini HMS, which will cause
the ClassNotFoundException when using notification log event listener.
This patch explicitly adds these jars.

Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
---
M src/kudu/hms/mini_hms.cc
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/11273/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifed85fffdabb5af19f22e343843e012b009888a0
Gerrit-Change-Number: 11273
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins