You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/02 22:42:44 UTC
[GitHub] [incubator-nuttx] cclauss opened a new pull request #3281: Lint Python code for syntax errors
cclauss opened a new pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281
https://flake8.pycqa.org/en/latest/user/error-codes.html
On the flake8 test selection, this PR does _not_ focus on "_style violations_" (the majority of flake8 error codes that [__psf/black__](https://github.com/psf/black) can autocorrect). Instead, these tests are focus on runtime safety and correctness:
* E9 tests are about Python syntax errors usually raised because flake8 can not build an Abstract Syntax Tree (AST). Often these issues are a sign of unused code or code that has not been ported to Python 3. These would be compile-time errors in a compiled language but in a dynamic language like Python, they result in the script halting/crashing on the user.
* F63 tests are usually about the confusion between identity and equality in Python. Use ==/!= to compare str, bytes, and int literals is the classic case. These are areas where __a == b__ is True but __a is b__ is False (or vice versa). Python >= 3.8 will raise SyntaxWarnings on these instances.
* F7 tests logic errors and syntax errors in type hints
* F82 tests are almost always _undefined names_ which are usually a sign of a typo, missing imports, or code that has not been ported to Python 3. These also would be compile-time errors in a compiled language but in Python, a __NameError__ is raised which will halt/crash the script on the user.
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cclauss edited a comment on pull request #3281: Lint Python code for syntax errors
Posted by GitBox <gi...@apache.org>.
cclauss edited a comment on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812819891
That linter might be super but it is also super slow. In its 5 minute runtime it should be able to automatically lint all programming languages known to man.
The test I added takes 5 second and actually finds code that would crash on the user. `black` if properly configured should should be unable to parse these two files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3281: Lint Python code for syntax errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812888798
But your second patch revert the first patch, and the third patch revert the partial second patch. It doesn't make sense to left your intermediate in the public git history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3281: Lint Python code for syntax errors
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812820388
It already includes flake8 black etc... We already have it for yaml linting why not just enable it for python as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3281: Lint Python code for syntax errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812823518
@cclauss could you squach your patches into one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3281: Lint Python code for syntax errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812888798
But your second patch revert the first patch, and the third patch revert the partial second patch. It doesn't make sense to left your intermediate change in the public git history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cclauss commented on pull request #3281: Lint Python code for syntax errors
Posted by GitBox <gi...@apache.org>.
cclauss commented on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812819891
That linter might be super but it is also super slow. In its 5 minute runtime it should be able to lint all programming languages known to man.
The test I added takes 5 second and actually finds code that would crash on the user. `black` if properly configured should should be unable to parse these two files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #3281: Lint Python code for syntax errors
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812790171
The GitHub super linter already can support this which we have enabled. You can just update the config for that.
It supports flake8 although to be honest I would be fine just having it use Black and then we have. Easy code style for python that can be auto formated.
https://github.com/github/super-linter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cclauss closed pull request #3281: Lint Python code for syntax errors
Posted by GitBox <gi...@apache.org>.
cclauss closed pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3281: Lint Python code for syntax errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812888930
And since you enable the additional check, please fix the error reported by Lint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #3281: Lint Python code for syntax errors
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812790171
The GitHub super linter already can support this which we have enabled. You just update the config for that.
It supports flake8 although to be honest I would be fine just having it use Black and then we have. Easy code style for python that can be auto formated.
https://github.com/github/super-linter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] cclauss commented on pull request #3281: Lint Python code for syntax errors
Posted by GitBox <gi...@apache.org>.
cclauss commented on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812883010
I do not usually squash commits of PRs that have failing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org