[GitHub] spark pull request: [SPARK-4606] Send EOF to child JVM when there'...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3460#discussion_r22241202
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitDriverBootstrapper.scala ---
    @@ -151,7 +151,8 @@ private[spark] object SparkSubmitDriverBootstrapper {
         val isWindows = Utils.isWindows
         val isSubprocess = sys.env.contains("IS_SUBPROCESS")
         if (!isWindows) {
    -      val stdinThread = new RedirectThread(System.in, process.getOutputStream, "redirect stdin")
    +      val stdinThread = new RedirectThread(System.in, process.getOutputStream, "redirect stdin",
    +        true)
    --- End diff --
    
    Kind of nitpicky, but I'd probably explicitly name the boolean parameter here (IntelliJ complains otherwise, and besides, it's a nice practice).  I can fix this up myself on merge, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org