You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "arshadmohammad (via GitHub)" <gi...@apache.org> on 2024/08/14 18:40:59 UTC

[PR] [Feature][Seatunnel-web] Add support to create job with single API [seatunnel-web]

arshadmohammad opened a new pull request, #184:
URL: https://github.com/apache/seatunnel-web/pull/184

   This PR adds support to create job in single call. You can create job with one API instead of calling following four API
   POST seatunnel/api/v1/job/definition
   POST seatunnel/api/v1/job/task/{jobVersionId}
   PUT seatunnel/api/v1/job/config/{jobVersionId}
   POST seatunnel/api/v1/job/dag/{jobVersionId}
   
   In jobDAG for inputPluginId and targetPluginId use the plugin configuration names instead of ids to make the API feasible.
   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Seatunnel-web] Add support to create job with single API [seatunnel-web]

Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on PR #184:
URL: https://github.com/apache/seatunnel-web/pull/184#issuecomment-2289675999

   "Backend / Unit Test (11, ubuntu-latest) (pull_request) " is failed becuase junit-jupiter-params-5.9.0.jar got corrupted. This is ci problem. This is not becuase of this PR change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Seatunnel-web] Add support to create job with single API [seatunnel-web]

Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on PR #184:
URL: https://github.com/apache/seatunnel-web/pull/184#issuecomment-2290802249

   Thanks @Hisoka-X  for reviewing and merging this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Seatunnel-web] Add support to create job with single API [seatunnel-web]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #184:
URL: https://github.com/apache/seatunnel-web/pull/184#issuecomment-2290508748

   Can the job created by the new API be echoed to the canvas normally?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Seatunnel-web] Add support to create job with single API [seatunnel-web]

Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on PR #184:
URL: https://github.com/apache/seatunnel-web/pull/184#issuecomment-2290763827

   **Yes, the job created by the new API is echoed to the canvas normally.**
   
   Becuase this API is generating exactly same data as it was created by below four APIs
   POST seatunnel/api/v1/job/definition
   POST seatunnel/api/v1/job/task/{jobVersionId}
   PUT seatunnel/api/v1/job/config/{jobVersionId}
   POST seatunnel/api/v1/job/dag/{jobVersionId}
   
   The new API is taking below input
   public class JobCreateReq {
       private JobConfig jobConfig;
       private List<PluginConfig> pluginConfigs;
       private JobDAG jobDAG;
   }
   
   JobConfig is the input for "PUT seatunnel/api/v1/job/config/{jobVersionId}"
   List<PluginConfig> pluginConfigs is the input for "POST seatunnel/api/v1/job/task/{jobVersionId}"
   JobDAG is the input for "POST seatunnel/api/v1/job/dag/{jobVersionId}"
   
   JobReq is the input for "POST seatunnel/api/v1/job/definition" API, which is taken indirectly.
   JobReq attribtues name,description and jobType are available in JobConfig.
   So JobReq is created from JobConfig and JobReq is handled the same way as it handled in "POST seatunnel/api/v1/job/definition" API.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Seatunnel-web] Add support to create job with single API [seatunnel-web]

Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on PR #184:
URL: https://github.com/apache/seatunnel-web/pull/184#issuecomment-2289680395

   ![image](https://github.com/user-attachments/assets/118b19b4-3219-4c14-a41f-3b500974a40c)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Seatunnel-web] Add support to create job with single API [seatunnel-web]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X merged PR #184:
URL: https://github.com/apache/seatunnel-web/pull/184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org