You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/05/04 03:48:09 UTC

[GitHub] [beam] AnandInguva opened a new pull request, #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

AnandInguva opened a new pull request, #17538:
URL: https://github.com/apache/beam/pull/17538

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tvalentyn commented on pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #17538:
URL: https://github.com/apache/beam/pull/17538#issuecomment-1117467242

   R: @ryanthompson591 
   
   We should remove side-effects of enabling and disabling cloudpickle in a test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] AnandInguva commented on pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #17538:
URL: https://github.com/apache/beam/pull/17538#issuecomment-1151224905

   > > PTAL @tvalentyn
   > > Forced pushed it as I have committed a different commit before :p
   > 
   > (replied in one of the comment threads above)
   
   Yep. I missed that one completely. I added the statement in `tearDown` method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tvalentyn commented on a diff in pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on code in PR #17538:
URL: https://github.com/apache/beam/pull/17538#discussion_r865037244


##########
sdks/python/apache_beam/runners/portability/stager_test.py:
##########
@@ -242,7 +242,7 @@ def test_with_main_session(self):
 
   # (BEAM-13769): Remove the decorator once cloudpickle is default pickle
   # library
-  @pytest.mark.skip
+  @pytest.mark.no_xdist

Review Comment:
   sometimes i have to grep but in this case github's search shows relevant results: https://github.com/apache/beam/search?q=no_xdist



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] ryanthompson591 commented on a diff in pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on code in PR #17538:
URL: https://github.com/apache/beam/pull/17538#discussion_r879738999


##########
sdks/python/apache_beam/runners/portability/stager_test.py:
##########
@@ -242,7 +242,7 @@ def test_with_main_session(self):
 
   # (BEAM-13769): Remove the decorator once cloudpickle is default pickle
   # library
-  @pytest.mark.skip
+  @pytest.mark.no_xdist

Review Comment:
   For context into what valentyn is ask for... do something like this:
   
   ```
   try:
     staging_dir = self.make_temp_dir()
       options = PipelineOptions()
       options.view_as(SetupOptions).save_main_session = True
       # even if the save main session is on, no pickle file for main
       # session is saved when pickle_library==cloudpickle.
       options.view_as(SetupOptions).pickle_library = pickler.USE_CLOUDPICKLE
       self.update_options(options)
       self.assertEqual([],
                        self.stager.create_and_stage_job_resources(
                            options, staging_location=staging_dir)[1])
   finally:
     # Revert pickle library to the default library.
     pickler.set_library(pickeler.DEFAULT)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] AnandInguva commented on a diff in pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #17538:
URL: https://github.com/apache/beam/pull/17538#discussion_r879769450


##########
sdks/python/apache_beam/runners/portability/stager_test.py:
##########
@@ -242,7 +242,7 @@ def test_with_main_session(self):
 
   # (BEAM-13769): Remove the decorator once cloudpickle is default pickle
   # library
-  @pytest.mark.skip
+  @pytest.mark.no_xdist

Review Comment:
   I think there is no need for try and final blocks. We can just set the value to default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] AnandInguva commented on a diff in pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #17538:
URL: https://github.com/apache/beam/pull/17538#discussion_r879769450


##########
sdks/python/apache_beam/runners/portability/stager_test.py:
##########
@@ -242,7 +242,7 @@ def test_with_main_session(self):
 
   # (BEAM-13769): Remove the decorator once cloudpickle is default pickle
   # library
-  @pytest.mark.skip
+  @pytest.mark.no_xdist

Review Comment:
   I think there is no need for try and final blocks. We can just set the value to default 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] ryanthompson591 commented on a diff in pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on code in PR #17538:
URL: https://github.com/apache/beam/pull/17538#discussion_r879983155


##########
sdks/python/apache_beam/runners/portability/stager_test.py:
##########
@@ -242,7 +242,7 @@ def test_with_main_session(self):
 
   # (BEAM-13769): Remove the decorator once cloudpickle is default pickle
   # library
-  @pytest.mark.skip
+  @pytest.mark.no_xdist

Review Comment:
   If the test fails, the value will not be the default after the test.  But yeah, I'm fine with either way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] AnandInguva commented on pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #17538:
URL: https://github.com/apache/beam/pull/17538#issuecomment-1142727044

   PTAL @tvalentyn


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tvalentyn merged pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
tvalentyn merged PR #17538:
URL: https://github.com/apache/beam/pull/17538


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tvalentyn commented on a diff in pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on code in PR #17538:
URL: https://github.com/apache/beam/pull/17538#discussion_r866911193


##########
sdks/python/apache_beam/runners/portability/stager_test.py:
##########
@@ -242,7 +242,7 @@ def test_with_main_session(self):
 
   # (BEAM-13769): Remove the decorator once cloudpickle is default pickle
   # library
-  @pytest.mark.skip
+  @pytest.mark.no_xdist

Review Comment:
   Can we restore the pickler library to the default value after the test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tvalentyn commented on a diff in pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on code in PR #17538:
URL: https://github.com/apache/beam/pull/17538#discussion_r879305563


##########
sdks/python/apache_beam/runners/portability/stager_test.py:
##########
@@ -242,7 +242,7 @@ def test_with_main_session(self):
 
   # (BEAM-13769): Remove the decorator once cloudpickle is default pickle
   # library
-  @pytest.mark.skip
+  @pytest.mark.no_xdist

Review Comment:
   Let's restore the value in addition to no_xdist.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tvalentyn commented on a diff in pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on code in PR #17538:
URL: https://github.com/apache/beam/pull/17538#discussion_r887156662


##########
sdks/python/apache_beam/runners/portability/stager_test.py:
##########
@@ -242,7 +242,7 @@ def test_with_main_session(self):
 
   # (BEAM-13769): Remove the decorator once cloudpickle is default pickle
   # library
-  @pytest.mark.skip
+  @pytest.mark.no_xdist

Review Comment:
   the important point is to reset the pickler *after* the test, not before the test, so as to avoid side-effects on other tests. so you'd need to put it in tearDown



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tvalentyn commented on pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #17538:
URL: https://github.com/apache/beam/pull/17538#issuecomment-1152347496

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17538:
URL: https://github.com/apache/beam/pull/17538#issuecomment-1116899968

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] AnandInguva commented on a diff in pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #17538:
URL: https://github.com/apache/beam/pull/17538#discussion_r886201421


##########
sdks/python/apache_beam/runners/portability/stager_test.py:
##########
@@ -242,7 +242,7 @@ def test_with_main_session(self):
 
   # (BEAM-13769): Remove the decorator once cloudpickle is default pickle
   # library
-  @pytest.mark.skip
+  @pytest.mark.no_xdist

Review Comment:
   I have put this in the setUp which should achieve the same thing. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tvalentyn commented on pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #17538:
URL: https://github.com/apache/beam/pull/17538#issuecomment-1151211106

   > PTAL @tvalentyn
   > 
   > Forced pushed it as I have committed a different commit before :p
   
   (replied in one of the comment threads above)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] ryanthompson591 commented on a diff in pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on code in PR #17538:
URL: https://github.com/apache/beam/pull/17538#discussion_r865006466


##########
sdks/python/apache_beam/runners/portability/stager_test.py:
##########
@@ -242,7 +242,7 @@ def test_with_main_session(self):
 
   # (BEAM-13769): Remove the decorator once cloudpickle is default pickle
   # library
-  @pytest.mark.skip
+  @pytest.mark.no_xdist

Review Comment:
   I'm just curious about where we access these markers in our test rules.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17538:
URL: https://github.com/apache/beam/pull/17538#issuecomment-1116899970

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] codecov[bot] commented on pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17538:
URL: https://github.com/apache/beam/pull/17538#issuecomment-1116907628

   # [Codecov](https://codecov.io/gh/apache/beam/pull/17538?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#17538](https://codecov.io/gh/apache/beam/pull/17538?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5f0edd4) into [master](https://codecov.io/gh/apache/beam/commit/0daef62a7bd993b13064de80588e343ee764e004?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0daef62) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #17538   +/-   ##
   =======================================
     Coverage   73.86%   73.86%           
   =======================================
     Files         690      690           
     Lines       91031    91044   +13     
   =======================================
   + Hits        67236    67251   +15     
   + Misses      22575    22573    -2     
     Partials     1220     1220           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `83.70% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/17538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/17538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.03% <0.00%> (-0.39%)` | :arrow_down: |
   | [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/17538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.51% <0.00%> (-0.13%)` | :arrow_down: |
   | [setup.py](https://codecov.io/gh/apache/beam/pull/17538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/typehints/schemas.py](https://codecov.io/gh/apache/beam/pull/17538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NjaGVtYXMucHk=) | `94.58% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/17538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5) | `63.87% <0.00%> (+0.10%)` | :arrow_up: |
   | [sdks/python/apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/17538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==) | `97.14% <0.00%> (+0.14%)` | :arrow_up: |
   | [sdks/python/apache\_beam/internal/dill\_pickler.py](https://codecov.io/gh/apache/beam/pull/17538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvZGlsbF9waWNrbGVyLnB5) | `87.05% <0.00%> (+0.71%)` | :arrow_up: |
   | [...python/apache\_beam/internal/cloudpickle\_pickler.py](https://codecov.io/gh/apache/beam/pull/17538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvY2xvdWRwaWNrbGVfcGlja2xlci5weQ==) | `86.27% <0.00%> (+1.96%)` | :arrow_up: |
   | [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/17538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (+2.43%)` | :arrow_up: |
   | [sdks/python/apache\_beam/internal/pickler.py](https://codecov.io/gh/apache/beam/pull/17538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvcGlja2xlci5weQ==) | `95.45% <0.00%> (+18.18%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17538?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17538?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0daef62...5f0edd4](https://codecov.io/gh/apache/beam/pull/17538?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org