You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@distributedlog.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/30 08:43:04 UTC
[jira] [Commented] (DL-205) Remove StatusCode dependency on
DLException
[ https://issues.apache.org/jira/browse/DL-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029172#comment-16029172 ]
ASF GitHub Bot commented on DL-205:
-----------------------------------
GitHub user sijie opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/131
DL-205: Remove StatusCode dependency on DLException
- Remove StatusCode from exceptions. Use integer as exception codes.
- Also re-organize the modules:
- [ ] distributedlog-protocol (for core structures) and distributedlog-core (for core library).
- [ ] proxy: distributedlog-proxy-protocol (new module for thrift generated protocol), distributedlog-proxy-client (proxy client) and distributedlog-proxy-server (proxy server)
- [ ] benchmark & tutorials.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sijie/incubator-distributedlog new_layout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/131.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #131
----
commit 54c2de047e1656e34ead7fb54070441afd9c140d
Author: Sijie Guo <si...@apache.org>
Date: 2017-05-26T22:05:43Z
Re-organize the distributedlog modules
- move proxy related class from protocol to proxy-protocol, changed client and service to proxy-client and proxy-service
commit 67e76150b103422f16883857a1c1345cf044fb45
Author: Sijie Guo <si...@apache.org>
Date: 2017-05-27T07:04:40Z
Use integration for exception code rather than thrift generated StatusCode
commit 03b2abd7bb97d4ca996e51329be3fcc485299416
Author: Sijie Guo <si...@apache.org>
Date: 2017-05-30T08:39:19Z
Fix the testcase related to status code change in exceptions
----
> Remove StatusCode dependency on DLException
> -------------------------------------------
>
> Key: DL-205
> URL: https://issues.apache.org/jira/browse/DL-205
> Project: DistributedLog
> Issue Type: Task
> Affects Versions: 0.4.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 0.5.0
>
>
> Currently DLException (and its sub-classes) are using the generated StatusCode as the exception code. It causes distributedlog-core unfortunately depend on libthrift 0.5.0 and scrooge.
> This change is to remove the StatusCode dependency.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)