You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by darionyaphet <gi...@git.apache.org> on 2016/06/11 11:32:22 UTC

[GitHub] storm pull request #1483: STORM-1875 : Separate Jedis/JedisCluster Config

GitHub user darionyaphet opened a pull request:

    https://github.com/apache/storm/pull/1483

    STORM-1875 : Separate Jedis/JedisCluster Config

    [STORM-1875](https://issues.apache.org/jira/browse/STORM-1875)  Separate Jedis / JedisCluster to provide full operations for each environment to users .
    
    Reference to : #1459 
    
    Separated existing classes to `RedisLookupBolt`  `RedisClusterLookupBolt` `RedisStoreBolt` `RedisClusterStoreBolt`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/darionyaphet/storm STORM-1875

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1483
    
----
commit e01e0f697539cbb5e84613e557f7ce8a00dab28c
Author: darionyaphet <da...@gmail.com>
Date:   2016-06-11T11:26:49Z

    STORM-1875 : Separate Jedis/JedisCluster Config

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1483: [STORM-1875] : Separate Jedis/JedisCluster Config

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1483


---

[GitHub] storm issue #1483: [STORM-1875] : Separate Jedis/JedisCluster Config

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1483
  
    It breaks backward compatibility so we can't go on this. 
    And in fact, separation of Jedis and JedisCluster is only needed when users want to use multiple keys operation, which is not applied to RedisLookupBolt and RedisStoreBolt.
    So it might be better to go with dirty way like I said later.
    
    I'm open to better ideas without breaking backward compatibility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---