You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/30 05:19:36 UTC
[GitHub] [rocketmq-streams] WesleyOne opened a new issue #127: fromFile not exist cause queue NPE
WesleyOne opened a new issue #127:
URL: https://github.com/apache/rocketmq-streams/issues/127
plz close this issue if same as #90
org.apache.rocketmq.streams.examples.source.FileSourceExample
if fromFile is not exist, will throwing NPE as below.
```
java.lang.NullPointerException
at org.apache.rocketmq.streams.common.channel.impl.file.FileSource.startSource(FileSource.java:90)
at org.apache.rocketmq.streams.common.channel.source.AbstractSource.start(AbstractSource.java:114)
at org.apache.rocketmq.streams.common.topology.ChainPipeline.startChannel(ChainPipeline.java:150)
at org.apache.rocketmq.streams.client.transform.DataStream$7.run(DataStream.java:714)
at java.lang.Thread.run(Thread.java:748)
```
how about fast-fail with throwing FileNotFoundException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] dongeforever commented on issue #127: fromFile not exist cause queue NPE
Posted by GitBox <gi...@apache.org>.
dongeforever commented on issue #127:
URL: https://github.com/apache/rocketmq-streams/issues/127#issuecomment-1030593191
@Kvicii Yeah. it is just be used for initialization, the capacity arg could be omitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] duhenglucky closed issue #127: fromFile not exist cause queue NPE
Posted by GitBox <gi...@apache.org>.
duhenglucky closed issue #127:
URL: https://github.com/apache/rocketmq-streams/issues/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] dongeforever commented on issue #127: fromFile not exist cause queue NPE
Posted by GitBox <gi...@apache.org>.
dongeforever commented on issue #127:
URL: https://github.com/apache/rocketmq-streams/issues/127#issuecomment-1030594641
@WesleyOne LGTM.
It's better to throw an exception when the initialization encounters an unexpected error.
It's not a good idea to treat the 'file not found error' as an empty stream.
you may submit a pr to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Kvicii commented on issue #127: fromFile not exist cause queue NPE
Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #127:
URL: https://github.com/apache/rocketmq-streams/issues/127#issuecomment-1025173830
@dongeforever hi there,
I think this kind of work to initialize capacity, if necessary, should be added with mandatory verification, but if the performance gap is not big, capacity initialization can be omitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Kvicii commented on issue #127: fromFile not exist cause queue NPE
Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #127:
URL: https://github.com/apache/rocketmq-streams/issues/127#issuecomment-1030594381
@dongeforever
Let me re-judg the size so that no NPE is thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Kvicii removed a comment on issue #127: fromFile not exist cause queue NPE
Posted by GitBox <gi...@apache.org>.
Kvicii removed a comment on issue #127:
URL: https://github.com/apache/rocketmq-streams/issues/127#issuecomment-1030594381
@dongeforever
Let me re-judg the size so that no NPE is thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] dongeforever edited a comment on issue #127: fromFile not exist cause queue NPE
Posted by GitBox <gi...@apache.org>.
dongeforever edited a comment on issue #127:
URL: https://github.com/apache/rocketmq-streams/issues/127#issuecomment-1030593191
@Kvicii The countdownlatch capacity is not for performance.
BTW, verification is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org