[GitHub] [geode] dschneider-pivotal commented on pull request #2954: GEODE-6066: Fixed cluster config update for error case

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

The problem I have with saying "data source saved to cluster config" is it might not happen. I suggest only adding this to the message here if "service" is not null. Even in that case should we say here: "will attempt to save to cluster configuration" instead? (Note: change "config" to "configuration" in customer facing message).
We will ask gfsh to make the attempt and it will follow it up with its own message telling us if it was saved to cluster config. It is not until "updateConfigForGroup" is called and returns true that we know the cluster config was actually saved.

[ Full content available at: https://github.com/apache/geode/pull/2954 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org