You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/21 15:04:52 UTC
[GitHub] NicoK commented on a change in pull request #6555:
[FLINK-10142][network] reduce locking around credit notification
NicoK commented on a change in pull request #6555: [FLINK-10142][network] reduce locking around credit notification
URL: https://github.com/apache/flink/pull/6555#discussion_r211641938
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
##########
@@ -357,19 +357,20 @@ private void writeAndFlushNextMessageIfPossible(Channel channel) {
return;
}
- //It is no need to notify credit for the released channel.
- if (!inputChannel.isReleased()) {
- AddCredit msg = new AddCredit(
- inputChannel.getPartitionId(),
- inputChannel.getAndResetUnannouncedCredit(),
- inputChannel.getInputChannelId());
+ if (inputChannel.isReleased()) {
Review comment:
irrelevant - that's an artefact of the backport of this patch to the plain 1.5 branch; I'll revert
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services