[jira] [Commented] (BEAM-1593) Remove access to the Pipeline Runner during Pipeline Construction

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892829#comment-15892829 ] 

ASF GitHub Bot commented on BEAM-1593:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2144

    [BEAM-1593] Remove Pipeline.getRunner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Runners need not be instantiated until after pipeline construction, so
    they should not be exposed by the Pipeline class.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam remove_runner_apply

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2144
    
----
commit 134b86cab6c178b4f40e6df086af033ca089826d
Author: Thomas Groh <tg...@google.com>
Date:   2017-03-02T18:54:29Z

    Remove Pipeline.getRunner
    
    Runners need not be instantiated until after pipeline construction, so
    they should not be exposed by the Pipeline class.

----


> Remove access to the Pipeline Runner during Pipeline Construction
> -----------------------------------------------------------------
>
>                 Key: BEAM-1593
>                 URL: https://issues.apache.org/jira/browse/BEAM-1593
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>            Priority: Minor
>
> Pipelines prior to the call to run are runner-independent, so PTransforms shouldn't have access to any knowledge about the runner.
> This consists of removing Pipeline.getRunner



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)