You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@quickstep.apache.org by sh...@apache.org on 2016/07/15 19:50:50 UTC
incubator-quickstep git commit: minor change
Repository: incubator-quickstep
Updated Branches:
refs/heads/SQL-window-aggregation ab9dc8b52 -> db0db5e68
minor change
Project: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/commit/db0db5e6
Tree: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/tree/db0db5e6
Diff: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/diff/db0db5e6
Branch: refs/heads/SQL-window-aggregation
Commit: db0db5e687cf582f8e32f9bf9bba832e358a5626
Parents: ab9dc8b
Author: shixuan-fan <sh...@apache.org>
Authored: Fri Jul 15 19:47:53 2016 +0000
Committer: shixuan-fan <sh...@apache.org>
Committed: Fri Jul 15 19:47:53 2016 +0000
----------------------------------------------------------------------
expressions/window_aggregation/CMakeLists.txt | 4 ----
expressions/window_aggregation/WindowAggregationHandle.hpp | 2 +-
expressions/window_aggregation/WindowAggregationHandleAvg.cpp | 2 +-
expressions/window_aggregation/WindowAggregationHandleAvg.hpp | 2 +-
4 files changed, 3 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/db0db5e6/expressions/window_aggregation/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/expressions/window_aggregation/CMakeLists.txt b/expressions/window_aggregation/CMakeLists.txt
index e696286..44e9b83 100644
--- a/expressions/window_aggregation/CMakeLists.txt
+++ b/expressions/window_aggregation/CMakeLists.txt
@@ -100,8 +100,6 @@ target_link_libraries(quickstep_expressions_windowaggregation_WindowAggregateFun
quickstep_expressions_windowaggregation_WindowAggregationHandle
quickstep_expressions_windowaggregation_WindowAggregationID
quickstep_types_Type
- quickstep_types_TypeFactory
- quickstep_types_TypeID
quickstep_types_operations_comparisons_Comparison
quickstep_types_operations_comparisons_ComparisonFactory
quickstep_types_operations_comparisons_ComparisonID
@@ -112,8 +110,6 @@ target_link_libraries(quickstep_expressions_windowaggregation_WindowAggregateFun
quickstep_expressions_windowaggregation_WindowAggregationHandle
quickstep_expressions_windowaggregation_WindowAggregationID
quickstep_types_Type
- quickstep_types_TypeFactory
- quickstep_types_TypeID
quickstep_types_operations_comparisons_Comparison
quickstep_types_operations_comparisons_ComparisonFactory
quickstep_types_operations_comparisons_ComparisonID
http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/db0db5e6/expressions/window_aggregation/WindowAggregationHandle.hpp
----------------------------------------------------------------------
diff --git a/expressions/window_aggregation/WindowAggregationHandle.hpp b/expressions/window_aggregation/WindowAggregationHandle.hpp
index 8863bad..ed6c88a 100644
--- a/expressions/window_aggregation/WindowAggregationHandle.hpp
+++ b/expressions/window_aggregation/WindowAggregationHandle.hpp
@@ -108,7 +108,7 @@ class WindowAggregationHandle {
const std::vector<attribute_id> &partition_by_ids,
const bool is_row,
const std::int64_t num_preceding,
- const std::int64_t num_following) = 0;
+ const std::int64_t num_following) const = 0;
protected:
/**
http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/db0db5e6/expressions/window_aggregation/WindowAggregationHandleAvg.cpp
----------------------------------------------------------------------
diff --git a/expressions/window_aggregation/WindowAggregationHandleAvg.cpp b/expressions/window_aggregation/WindowAggregationHandleAvg.cpp
index acc19fe..eb6a14b 100644
--- a/expressions/window_aggregation/WindowAggregationHandleAvg.cpp
+++ b/expressions/window_aggregation/WindowAggregationHandleAvg.cpp
@@ -93,7 +93,7 @@ ColumnVector* WindowAggregationHandleAvg::calculate(
const std::vector<attribute_id> &partition_by_ids,
const bool is_row,
const std::int64_t num_preceding,
- const std::int64_t num_following) {
+ const std::int64_t num_following) const {
DCHECK_EQ(1u, arguments.size());
DCHECK(arguments[0]->isNative());
DCHECK_EQ(static_cast<std::size_t>(tuple_accessor->getNumTuples()),
http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/db0db5e6/expressions/window_aggregation/WindowAggregationHandleAvg.hpp
----------------------------------------------------------------------
diff --git a/expressions/window_aggregation/WindowAggregationHandleAvg.hpp b/expressions/window_aggregation/WindowAggregationHandleAvg.hpp
index e0b630a..4e42034 100644
--- a/expressions/window_aggregation/WindowAggregationHandleAvg.hpp
+++ b/expressions/window_aggregation/WindowAggregationHandleAvg.hpp
@@ -60,7 +60,7 @@ class WindowAggregationHandleAvg : public WindowAggregationHandle {
const std::vector<attribute_id> &partition_by_ids,
const bool is_row,
const std::int64_t num_preceding,
- const std::int64_t num_following);
+ const std::int64_t num_following) const override;
private:
friend class WindowAggregateFunctionAvg;