You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/04/05 14:22:15 UTC
[GitHub] [superset] sebastianliebscher opened a new pull request, #23587: fix(docker-compose): Make worker use correct healthcheck (#23455)
sebastianliebscher opened a new pull request, #23587:
URL: https://github.com/apache/superset/pull/23587
### SUMMARY
Since Celery 5.0 the global options (-A, --app) [can no longer](https://docs.celeryq.dev/en/stable/history/whatsnew-5.0.html#step-1-adjust-your-command-line-invocation) be positioned after the sub-command. Instead, they must be positioned as an option for the celery command. This PR correctly positions the global option for the celery-healthcheck in docker-compose.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
```
CONTAINER ID IMAGE COMMAND STATUS PORTS NAMES
58252b3d19e5 apache/superset:latest-dev "/app/docker/docker-…" Up About an hour (unhealthy) 8088/tcp superset_worker
```
After:
```
CONTAINER ID IMAGE COMMAND STATUS PORTS NAMES
a02f26ae8921 apache/superset:latest-dev "/app/docker/docker-…" Up About an hour (healthy) 8088/tcp superset_worker
```
### TESTING INSTRUCTIONS
```docker-compose up```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: fixes #23042 and #23455
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #23587: fix(docker-compose): Make worker use correct healthcheck (#23455)
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #23587:
URL: https://github.com/apache/superset/pull/23587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org