You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/22 01:35:45 UTC

[GitHub] [apisix] spacewander edited a comment on pull request #3624: feat: add pre-commit framework

spacewander edited a comment on pull request #3624:
URL: https://github.com/apache/apisix/pull/3624#issuecomment-782981097


   The pre-commit framework is good.
   But does it add any value as we already check them in the CI? There are many duplicate rules between this framework and the CI files. I don't want to increase the maintain burden and make amateur harder to do contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org