You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/31 10:21:52 UTC

[GitHub] [ozone] bshashikant opened a new pull request #2099: HDDS-5049. Add timeout support for ratis requests in SCM HA.

bshashikant opened a new pull request #2099:
URL: https://github.com/apache/ozone/pull/2099


   ## What changes were proposed in this pull request?
   Added Timeout support for ratis requests.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-5049
   
   ## How was this patch tested?
   
   Existing UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] GlenGeng commented on a change in pull request #2099: HDDS-5049. Add timeout support for ratis requests in SCM HA.

Posted by GitBox <gi...@apache.org>.
GlenGeng commented on a change in pull request #2099:
URL: https://github.com/apache/ozone/pull/2099#discussion_r605346924



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -467,6 +467,11 @@
   public static final TimeDuration OZONE_SCM_RATIS_MINIMUM_TIMEOUT_DEFAULT
       = TimeDuration.valueOf(1, TimeUnit.SECONDS);
 
+  public static final String OZONE_SCM_RATIS_REQUEST_TIMEOUT_KEY
+      = "ozone.scm.ratis.minimum.timeout";

Review comment:
       Sure. Thanks for creating the jira.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] GlenGeng commented on pull request #2099: HDDS-5049. Add timeout support for ratis requests in SCM HA.

Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #2099:
URL: https://github.com/apache/ozone/pull/2099#issuecomment-811608056


   +1. Thanks @bshashikant for the work. I will merge it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bshashikant commented on a change in pull request #2099: HDDS-5049. Add timeout support for ratis requests in SCM HA.

Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #2099:
URL: https://github.com/apache/ozone/pull/2099#discussion_r605030188



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -467,6 +467,11 @@
   public static final TimeDuration OZONE_SCM_RATIS_MINIMUM_TIMEOUT_DEFAULT
       = TimeDuration.valueOf(1, TimeUnit.SECONDS);
 
+  public static final String OZONE_SCM_RATIS_REQUEST_TIMEOUT_KEY
+      = "ozone.scm.ratis.minimum.timeout";

Review comment:
       I think, we should be remove SCMHAConfiguration and pull all the required configs in ScmConfigKeys and remove the unused ones. But, i would prefer to do this as a part of different jira altogether.
   
   https://issues.apache.org/jira/browse/HDDS-5054 is opened to track the same.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] GlenGeng merged pull request #2099: HDDS-5049. Add timeout support for ratis requests in SCM HA.

Posted by GitBox <gi...@apache.org>.
GlenGeng merged pull request #2099:
URL: https://github.com/apache/ozone/pull/2099


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] GlenGeng commented on a change in pull request #2099: HDDS-5049. Add timeout support for ratis requests in SCM HA.

Posted by GitBox <gi...@apache.org>.
GlenGeng commented on a change in pull request #2099:
URL: https://github.com/apache/ozone/pull/2099#discussion_r604843105



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -467,6 +467,11 @@
   public static final TimeDuration OZONE_SCM_RATIS_MINIMUM_TIMEOUT_DEFAULT
       = TimeDuration.valueOf(1, TimeUnit.SECONDS);
 
+  public static final String OZONE_SCM_RATIS_REQUEST_TIMEOUT_KEY
+      = "ozone.scm.ratis.minimum.timeout";

Review comment:
       Should we add the key to `SCMHAConfiguration` ? 
   BTW, the key `OZONE_SCM_RATIS_SERVER_REQUEST_TIMEOUT_KEY`, `OZONE_SCM_RATIS_SERVER_RETRY_CACHE_TIMEOUT_KEY`, `OZONE_SCM_RATIS_MINIMUM_TIMEOUT_KEY`, `OZONE_SCM_LEADER_ELECTION_MINIMUM_TIMEOUT_DURATION_KEY` etc are not used any more. Better clean up them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bshashikant commented on pull request #2099: HDDS-5049. Add timeout support for ratis requests in SCM HA.

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #2099:
URL: https://github.com/apache/ozone/pull/2099#issuecomment-810954509


   @GlenGeng , can you have a look?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bshashikant commented on a change in pull request #2099: HDDS-5049. Add timeout support for ratis requests in SCM HA.

Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #2099:
URL: https://github.com/apache/ozone/pull/2099#discussion_r605030188



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -467,6 +467,11 @@
   public static final TimeDuration OZONE_SCM_RATIS_MINIMUM_TIMEOUT_DEFAULT
       = TimeDuration.valueOf(1, TimeUnit.SECONDS);
 
+  public static final String OZONE_SCM_RATIS_REQUEST_TIMEOUT_KEY
+      = "ozone.scm.ratis.minimum.timeout";

Review comment:
       I think, we should be remove SCMHAConfiguration and pull all the required configs in ScmConfigKeys and remove the unused ones. But, i would prefer to do this as a part of different jira altogether.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org