[jira] [Commented] (GIRAPH-678) Disorder of vertex de-serialization and 'initialize' method

["Claudio Martella (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674539#comment-13674539 ] 

Claudio Martella commented on GIRAPH-678:
-----------------------------------------

could you provide a patch please?
                
> Disorder of vertex de-serialization and 'initialize' method
> -----------------------------------------------------------
>
>                 Key: GIRAPH-678
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-678
>             Project: Giraph
>          Issue Type: Bug
>          Components: graph
>    Affects Versions: 1.0.0, 1.1.0
>         Environment: Giraph 1.0, hadoop 0.20.2
>            Reporter: David Zhang
>
> In org.apache.giraph.utils.Writable.readVertexFromDataInput method.
> 'initialize' method is ahead of vertex de-serialization.
> Change the order is ok:
>   public static <I extends WritableComparable, V extends Writable,
>   E extends Writable, M extends Writable> Vertex<I, V, E, M>
>   readVertexFromDataInput(
>       DataInput input,
>       ImmutableClassesGiraphConfiguration<I, V, E, M> conf)
>     throws IOException {
>     Vertex<I, V, E, M> vertex = conf.createVertex();
>     I id = conf.createVertexId();
>     V value = conf.createVertexValue();
>     OutEdges<I, E> edges = conf.createOutEdges();
>     id.readFields(input);
>     value.readFields(input);
>     edges.readFields(input);
>     if (input.readBoolean()) {
>       vertex.voteToHalt();
>     } else {
>       vertex.wakeUp();
>     }
>     vertex.initialize(id, value, edges);
>     return vertex;
>   }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira