[GitHub] [skywalking-banyandb] hanahmily commented on a change in pull request #36: Add dockerfile

[GitBox <gi...@apache.org>]

hanahmily commented on a change in pull request #36:
URL: https://github.com/apache/skywalking-banyandb/pull/36#discussion_r689989604



##########
File path: Makefile
##########
@@ -105,6 +120,17 @@ license-check: ## Check license header
 license-fix: ## Fix license header issues
 	 docker run -it --rm -v $(mk_dir):/github/workspace apache/skywalking-eyes header fix
 
+##@ Docker targets
+
+.PHONY: docker
+docker:
+	@echo "Build Skywalking/BanyanDB Docker Image"
+	@time (docker buildx build $(BUILD_ARGS) -t $(HUB):$(TAG) -f Dockerfile .)
+
+.PHONY: docker.push
+docker.push:
+	@echo "Push Skywalking/BanyanDB Docker Image"
+	time (docker push $(HUB):$(TAG))

Review comment:
       Refactoring them as other tasks 

##########
File path: Dockerfile
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       Pls move this into banyand folder 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org