You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by mi...@apache.org on 2016/08/30 09:27:20 UTC
[03/24] logging-log4j2 git commit: Use try-with-resources for JDBC
resources.
Use try-with-resources for JDBC resources.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/c4962aa3
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/c4962aa3
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/c4962aa3
Branch: refs/heads/LOG4J2-1528
Commit: c4962aa3ba7decccdd4338b6763b3123d68045b3
Parents: 11930be
Author: Gary Gregory <gg...@apache.org>
Authored: Sun Aug 28 13:32:42 2016 -0700
Committer: Gary Gregory <gg...@apache.org>
Committed: Sun Aug 28 13:32:42 2016 -0700
----------------------------------------------------------------------
.../core/appender/db/jdbc/AbstractJdbcAppenderTest.java | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/c4962aa3/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jdbc/AbstractJdbcAppenderTest.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jdbc/AbstractJdbcAppenderTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jdbc/AbstractJdbcAppenderTest.java
index 2d5f6ce..4d8cda9 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jdbc/AbstractJdbcAppenderTest.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jdbc/AbstractJdbcAppenderTest.java
@@ -83,18 +83,8 @@ public abstract class AbstractJdbcAppenderTest {
context.reconfigure();
StatusLogger.getLogger().reset();
- Statement statement = null;
- try {
- statement = this.connection.createStatement();
+ try (Statement statement = this.connection.createStatement()) {
statement.execute("SHUTDOWN");
- } finally {
- try {
- if (statement != null) {
- statement.close();
- }
- } catch (final SQLException ignore) {
- /* */
- }
}
this.connection.close();