You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org> on 2012/01/06 08:29:40 UTC
[jira] [Commented] (HBASE-5134) Remove
getRegionServerWithoutRetries and getRegionServerWithRetries from
HConnection Interface
[ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181181#comment-13181181 ]
Lars Hofhansl commented on HBASE-5134:
--------------------------------------
+1... Didn't even realize that's what's happening. At least HConnectionImplementation and HTable do the right thing and pass themselves (HConnctionImpl) or the right HConnection (HTable) when creating the ServerCallable.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-5134
> URL: https://issues.apache.org/jira/browse/HBASE-5134
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
>
> Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira