[GitHub] [helix] jiajunwang commented on pull request #1644: Fix TaskStateModelFactory no msds endpoint multizk situation

[GitBox <gi...@apache.org>]

jiajunwang commented on pull request #1644:
URL: https://github.com/apache/helix/pull/1644#issuecomment-776235521


   An alternative way that I think would be cleaner and future proof, we make the create ZkClient method in the HelixManager public. Of course, we may need to refine this method since it is for now a private method only. But as long as it is done, the HelixManager users no longer need to care about the internal details. The manager object just generates a new client according to the initial config.
   
   This is a proposal I thought for a while. There are several benefits,
   1. Hide details, as mentioned above.
   2. Potentially simplifying code. We can even enforce all the Helix user to create client through a HelixManager in the future. So this class becomes the only one who understands the necessary mess.
   3. Potentially a better place (or another handy layer) to manage connections compared with the other static pool object.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org