[jira] Resolved: (HADOOP-5553) Change modifier of SequenceFile.CompressedBytes and SequenceFile.UncompressedBytes from private to public

["Chris Douglas (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-5553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas resolved HADOOP-5553.
-----------------------------------

    Resolution: Won't Fix

Disallowing user extension here is exactly the right choice. An interface to a family of binary readers for a file format adds another layer of support, and I can imagine no other use than the one you propose: avoiding the full read into memory.

Instead of making these inner classes public, perhaps this functionality could be added to SequenceFile. Then the community benefits, rather than being burdened with its maintenance.

> Change modifier of SequenceFile.CompressedBytes and SequenceFile.UncompressedBytes from private to public
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5553
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5553
>             Project: Hadoop Core
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>         Attachments: Hadoop-5553-2.patch, Hadoop-5553-3.patch, Hadoop-5553.patch
>
>
> SequenceFile.rawValue() provides the only interface to navigate the underlying bytes. And with some little work on implementing a customized ValueBytes can avoid reading all bytes into memory. Unfortunately, the current nextRawValue will cast the passing ValueBytes to either private class CompressedBytes or private class UnCompressedBytes, this will disallow user further extension.
> I can not see any reason that CompressedBytes and UnCompressedBytes should be set to private. And since the ValueBytes is public and nextValue() casts it to either CompressedBytes or UnCompressedBytes, i think it would be better if they are public.
> I am stuck now by this issue, really appracited if this got resolved as soon as possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.