You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/09/14 18:31:12 UTC
[kudu-CR] [iwyu] introduce Linux system mappings
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8071
Change subject: [iwyu] introduce Linux system mappings
......................................................................
[iwyu] introduce Linux system mappings
For starters, added the following mappings to achieve better
compatibility across different Linus versions and distros:
* use <linux/kernel.h> even if <linux/sysinfo.h> is available
* use <sys/vfs.h> even if <sys/statfs.h> is available
* use <linux/types.h> as an umbrella header file for various asm types
Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
---
M build-support/iwyu/iwyu-filter.awk
M build-support/iwyu/iwyu.sh
A build-support/iwyu/mappings/system-linux.imp
M src/kudu/util/env_posix.cc
4 files changed, 47 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8071/1
--
To view, visit http://gerrit.cloudera.org:8080/8071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [iwyu] introduce Linux system mappings
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8071
to look at the new patch set (#3).
Change subject: [iwyu] introduce Linux system mappings
......................................................................
[iwyu] introduce Linux system mappings
For starters, added the following mappings to achieve better
compatibility across different Linus versions and distros:
* use <linux/kernel.h> even if <linux/sysinfo.h> is available
* use <sys/vfs.h> even if <sys/statfs.h> is available
* use <linux/types.h> as an umbrella header file for various asm types
Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
---
M build-support/iwyu/iwyu-filter.awk
M build-support/iwyu/iwyu.sh
A build-support/iwyu/mappings/system-linux.imp
M src/kudu/util/env_posix.cc
4 files changed, 48 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8071/3
--
To view, visit http://gerrit.cloudera.org:8080/8071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [iwyu] introduce Linux system mappings
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [iwyu] introduce Linux system mappings
......................................................................
[iwyu] introduce Linux system mappings
For starters, added the following mappings to achieve better
compatibility across different Linus versions and distros:
* use <linux/kernel.h> even if <linux/sysinfo.h> is available
* use <sys/vfs.h> even if <sys/statfs.h> is available
* use <linux/types.h> as an umbrella header file for various asm types
Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
Reviewed-on: http://gerrit.cloudera.org:8080/8071
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/iwyu/iwyu-filter.awk
M build-support/iwyu/iwyu.sh
A build-support/iwyu/mappings/system-linux.imp
M src/kudu/util/env_posix.cc
4 files changed, 48 insertions(+), 13 deletions(-)
Approvals:
Andrew Wong: Looks good to me, but someone else must approve
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] [iwyu] introduce Linux system mappings
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [iwyu] introduce Linux system mappings
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8071/1/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 79: #include <sys/vfs.h> // IWYU pragma: keep
Still need this pragma?
--
To view, visit http://gerrit.cloudera.org:8080/8071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [iwyu] introduce Linux system mappings
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [iwyu] introduce Linux system mappings
......................................................................
[iwyu] introduce Linux system mappings
For starters, added the following mappings to achieve better
compatibility across different Linus versions and distros:
* use <linux/kernel.h> even if <linux/sysinfo.h> is available
* use <sys/vfs.h> even if <sys/statfs.h> is available
* use <linux/types.h> as an umbrella header file for various asm types
Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
---
M build-support/iwyu/iwyu-filter.awk
M build-support/iwyu/iwyu.sh
A build-support/iwyu/mappings/system-linux.imp
M src/kudu/util/env_posix.cc
4 files changed, 48 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8071/2
--
To view, visit http://gerrit.cloudera.org:8080/8071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [iwyu] introduce Linux system mappings
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change.
Change subject: [iwyu] introduce Linux system mappings
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] [iwyu] introduce Linux system mappings
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [iwyu] introduce Linux system mappings
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] [iwyu] introduce Linux system mappings
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] introduce Linux system mappings
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8071/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 73: #include <linux/kernel.h>
> warning: #includes are not sorted properly [llvm-include-order]
Done
--
To view, visit http://gerrit.cloudera.org:8080/8071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] [iwyu] introduce Linux system mappings
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] introduce Linux system mappings
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8071/1/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 79: #include <sys/vfs.h> // IWYU pragma: keep
> Still need this pragma?
Good catch! Nope, this is no longer needed.
--
To view, visit http://gerrit.cloudera.org:8080/8071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e50f9135fa076e429b26e3919ef19eb5d430173
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes