You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@spamassassin.apache.org by Duane Hill <d....@yournetplus.com> on 2007/05/23 15:11:07 UTC

bayes autolearn - nonspam threshold

Since the introduction of SA v3.2.0, bayes_auto_learn_threshold_nonspam 
appears to be -1.0.

I realize in the code, 0.1 is the default set:

   push (@cmds, {
     setting => 'bayes_auto_learn_threshold_nonspam',
     default => 0.1,
     type => $Mail::SpamAssassin::Conf::CONF_TYPE_NUMERIC
   });

I just did a brand new install (FreeBSD v6.2, SA 3.2) in a virtual server. 
I have not ran any updating. The threshold running is -1.0.

The threshold value is being overridden by a config file that was 
installed from the distribution package:

% grep nonspam /usr/local/share/spamassassin/10_default_prefs.cf
bayes_auto_learn_threshold_nonspam     -1.0

Therefore, anyone using SA 3.2 who was a prior version without the 
bayes_auto_learn_threshold_nonspam setting will ultimately have to set the 
value now to 0.1. Therefore, the code default will never be taken as a 
default as long as bayes_auto_learn_threshold_nonspam lives in 
10_default_prefs.cf.

RE: bayes autolearn - nonspam threshold

Posted by "AbbaComm.Net" <li...@abbacomm.net>.
> If you word the note appropriately there would be no need to change it
> again. Something along the lines of "Also note that, like all such
> settings, the default values can be overridden by configuration files
> including those downloaded using sa-update. For example, the official
> sa-update channel for SpamAssassin 3.2.0 included a nonspam threshold
> setting of 1.0 on <insert date here>; this setting could of course be
> changed again with a subsequent update."
> 
> John

John,

That is a good idea in general, and realistically it is almost a given, yet
why does the program code or .cf files need to have it in more than one
place let alone allow another place to change it?

Any why would they negate each other anyways?

Mostly focusing on why in the in some program code and in a different .cf
file beside local.cf right now

 - rh

--
Abba Communications
Spokane, WA
www.abbacomm.net


Re: bayes autolearn - nonspam threshold

Posted by jo...@tradoc.fr.
Quoting Theo Van Dinter <fe...@apache.org>:
> On Wed, May 23, 2007 at 05:50:41PM +0200, John Wilcock wrote:
>> I don't see what harm could be done by adding a note in the
>> documentation to point out that this default can be (and has been)
>> updated using sa-update.
>
> So, hypothetically, next week when the update removes this change, should we
> update the documentation again to remove the now inaccurate "an update has
> changed the default"?
>
> How about if SARE, or any other channel publisher puts in config line to
> change the setting?

If you word the note appropriately there would be no need to change it  
again. Something along the lines of "Also note that, like all such  
settings, the default values can be overridden by configuration files  
including those downloaded using sa-update. For example, the official  
sa-update channel for SpamAssassin 3.2.0 included a nonspam threshold  
setting of 1.0 on <insert date here>; this setting could of course be  
changed again with a subsequent update."

John?


Re: bayes autolearn - nonspam threshold

Posted by Theo Van Dinter <fe...@apache.org>.
On Wed, May 23, 2007 at 05:50:41PM +0200, John Wilcock wrote:
> I don't see what harm could be done by adding a note in the 
> documentation to point out that this default can be (and has been) 
> updated using sa-update.

So, hypothetically, next week when the update removes this change, should we
update the documentation again to remove the now inaccurate "an update has
changed the default"?

How about if SARE, or any other channel publisher puts in config line to
change the setting?

-- 
Randomly Selected Tagline:
Die, v.:  To stop sinning suddenly.

Re: bayes autolearn - nonspam threshold

Posted by John Wilcock <jo...@tradoc.fr>.
Jim Maul wrote:
> It is somewhat confusing as if you were to read the documentation, it 
> says the default is 0.1.  However, if you were to download SA and 
> install it without any modifications, the value that would be used for 
> this threshold would be -1.  Being that devs can release conf changes 
> which can alter defaults, but they cannot update the documentation in 
> this manner, what do you suggest as an alternative?  There really is no 
> other way to do it.
> 
> So, yes, its confusing, but there really isnt a better way to do it.

While I fully understand the argument about code and config, not all 
users will.

I don't see what harm could be done by adding a note in the 
documentation to point out that this default can be (and has been) 
updated using sa-update.

John.

-- 
-- Over 3000 webcams from ski resorts around the world - www.snoweye.com
-- Translate your technical documents and web pages    - www.tradoc.fr

Re: bayes autolearn - nonspam threshold

Posted by Duane Hill <d....@yournetplus.com>.
On Wed, 23 May 2007, Jim Maul wrote:

> Duane Hill wrote:
>> On Wed, 23 May 2007, Abba Communications wrote:
>> 
>>>> 
>>>> Since the introduction of SA v3.2.0, bayes_auto_learn_threshold_nonspam
>>>> appears to be -1.0.
>>>> from Duane
>>> 
>>> Duane and others....
>>> 
>>> With all sincere and due respect to the DEV's and their excellent hard
>>> work...
>> 
>> I understand it takes a lot of work to maintain and appriciate the efforts 
>> put forth.
>> 
>>> Just how many places should this setting be???
>> 
>> Well, it version 3.1.8 it wasn't anywhere to be found in a configuration 
>> file. You had to have the setting in place to deviate from 0.1.
>> 
>> So why not remove the setting from 10_default_prefs.cf (a core setting file 
>> installed from the distribution) and have the code default do what it 
>> should. Defaults are to handle issues where a setting isn't specified.
>> 
>
> The code never changed.  It still defaults to 0.1
>
> Somewhere along the line, someone decided it should be -1.  The only way to 
> change this is to:
>
> 1. Change the code and release a new version (stupid for such a small change)
> 2. Make the change in a conf file by specifying a new value and distribute 
> that change to all using sa-update.
>
> Obviously, the devs chose option 2.  What this in effect does is change the 
> default autolearn threshold for the SA installation.  It however does not 
> change the default in the code as sa-update cannot update core SA code.  It 
> also cannot update the documentation that comes with SA.
>
>>> I can understand it being in some type of conditional statement in code if
>>> the setting does not exist in the local.cf file, yet this is getting to be 
>>> a
>>> tad confusing now...
>
>
> It is somewhat confusing as if you were to read the documentation, it says 
> the default is 0.1.  However, if you were to download SA and install it 
> without any modifications, the value that would be used for this threshold 
> would be -1.  Being that devs can release conf changes which can alter 
> defaults, but they cannot update the documentation in this manner, what do 
> you suggest as an alternative?  There really is no other way to do it.
>
> So, yes, its confusing, but there really isnt a better way to do it.

You have 100% cleared up my confusion at least. Thanks for the response. I 
go in peace and sorry for disturbing everyone on this petty thing I was 
confused about.

Re: bayes autolearn - nonspam threshold

Posted by Jim Maul <jm...@elih.org>.
Duane Hill wrote:
> On Wed, 23 May 2007, Abba Communications wrote:
> 
>>>
>>> Since the introduction of SA v3.2.0, bayes_auto_learn_threshold_nonspam
>>> appears to be -1.0.
>>> from Duane
>>
>> Duane and others....
>>
>> With all sincere and due respect to the DEV's and their excellent hard
>> work...
> 
> I understand it takes a lot of work to maintain and appriciate the 
> efforts put forth.
> 
>> Just how many places should this setting be???
> 
> Well, it version 3.1.8 it wasn't anywhere to be found in a configuration 
> file. You had to have the setting in place to deviate from 0.1.
> 
> So why not remove the setting from 10_default_prefs.cf (a core setting 
> file installed from the distribution) and have the code default do what 
> it should. Defaults are to handle issues where a setting isn't specified.
> 

The code never changed.  It still defaults to 0.1

Somewhere along the line, someone decided it should be -1.  The only way 
to change this is to:

1. Change the code and release a new version (stupid for such a small 
change)
2. Make the change in a conf file by specifying a new value and 
distribute that change to all using sa-update.

Obviously, the devs chose option 2.  What this in effect does is change 
the default autolearn threshold for the SA installation.  It however 
does not change the default in the code as sa-update cannot update core 
SA code.  It also cannot update the documentation that comes with SA.

>> I can understand it being in some type of conditional statement in 
>> code if
>> the setting does not exist in the local.cf file, yet this is getting 
>> to be a
>> tad confusing now...


It is somewhat confusing as if you were to read the documentation, it 
says the default is 0.1.  However, if you were to download SA and 
install it without any modifications, the value that would be used for 
this threshold would be -1.  Being that devs can release conf changes 
which can alter defaults, but they cannot update the documentation in 
this manner, what do you suggest as an alternative?  There really is no 
other way to do it.

So, yes, its confusing, but there really isnt a better way to do it.

-Jim

RE: bayes autolearn - nonspam threshold

Posted by Duane Hill <d....@yournetplus.com>.
On Wed, 23 May 2007, Abba Communications wrote:

>>
>> Since the introduction of SA v3.2.0, bayes_auto_learn_threshold_nonspam
>> appears to be -1.0.
>> from Duane
>
> Duane and others....
>
> With all sincere and due respect to the DEV's and their excellent hard
> work...

I understand it takes a lot of work to maintain and appriciate the efforts 
put forth.

> Just how many places should this setting be???

Well, it version 3.1.8 it wasn't anywhere to be found in a configuration 
file. You had to have the setting in place to deviate from 0.1.

So why not remove the setting from 10_default_prefs.cf (a core setting 
file installed from the distribution) and have the code default do what it 
should. Defaults are to handle issues where a setting isn't specified.

> I can understand it being in some type of conditional statement in code if
> the setting does not exist in the local.cf file, yet this is getting to be a
> tad confusing now...

Sorry for the confusion. I'm going to quitely refrain from this discussion 
as it is going nowhere.

RE: bayes autolearn - nonspam threshold

Posted by Abba Communications <li...@abbacomm.net>.
> 
> Since the introduction of SA v3.2.0, bayes_auto_learn_threshold_nonspam
> appears to be -1.0.
> from Duane

Duane and others....

With all sincere and due respect to the DEV's and their excellent hard
work...

Just how many places should this setting be???

I can understand it being in some type of conditional statement in code if
the setting does not exist in the local.cf file, yet this is getting to be a
tad confusing now...

:-)

 - rh

--
Abba Communications
Spokane, WA
www.abbacomm.net