You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/17 11:16:36 UTC
[GitHub] [hudi] sekaiga opened a new pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
sekaiga opened a new pull request #5060:
URL: https://github.com/apache/hudi/pull/5060
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1070871135
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ca61208eb5006ee7ad31912f5a6a6d18c5efd46 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1086849716
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "b4f82659a528abea9ebbdc872bd8e59a80d9aa2a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7790",
"triggerID" : "b4f82659a528abea9ebbdc872bd8e59a80d9aa2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066)
* b4f82659a528abea9ebbdc872bd8e59a80d9aa2a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7790)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1070807639
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ca61208eb5006ee7ad31912f5a6a6d18c5efd46 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1086849029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "b4f82659a528abea9ebbdc872bd8e59a80d9aa2a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b4f82659a528abea9ebbdc872bd8e59a80d9aa2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066)
* b4f82659a528abea9ebbdc872bd8e59a80d9aa2a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sekaiga commented on a change in pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
sekaiga commented on a change in pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#discussion_r841210698
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java
##########
@@ -54,6 +54,8 @@
* @author Attila Szegedi
*/
public class ObjectSizeCalculator {
+ private static final ThreadLocal<ObjectSizeCalculator> objectSizeCalculator = ThreadLocal.withInitial(() -> new ObjectSizeCalculator(CurrentLayout.SPEC));
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072149134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sekaiga commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
sekaiga commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072073070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars commented on a change in pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on a change in pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#discussion_r836029823
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java
##########
@@ -54,6 +54,8 @@
* @author Attila Szegedi
*/
public class ObjectSizeCalculator {
+ private static final ThreadLocal<ObjectSizeCalculator> objectSizeCalculator = ThreadLocal.withInitial(() -> new ObjectSizeCalculator(CurrentLayout.SPEC));
Review comment:
The constant name does not conform to the specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072149134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072093211
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072093211
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a change in pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on a change in pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#discussion_r829607531
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java
##########
@@ -92,6 +92,7 @@ public static long getObjectSize(Object obj) throws UnsupportedOperationExceptio
private final Set<Object> alreadyVisited = Collections.newSetFromMap(new IdentityHashMap<>());
private final Deque<Object> pending = new ArrayDeque<>(64);
private long size;
+ private static final ThreadLocal<ObjectSizeCalculator> objectSizeCalculator = ThreadLocal.withInitial(() -> new ObjectSizeCalculator(CurrentLayout.SPEC));
Review comment:
Let's bubble this up to the top of the declarations list (where all the static members are)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#discussion_r829665766
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java
##########
@@ -92,6 +92,7 @@ public static long getObjectSize(Object obj) throws UnsupportedOperationExceptio
private final Set<Object> alreadyVisited = Collections.newSetFromMap(new IdentityHashMap<>());
private final Deque<Object> pending = new ArrayDeque<>(64);
private long size;
+ private static final ThreadLocal<ObjectSizeCalculator> objectSizeCalculator = ThreadLocal.withInitial(() -> new ObjectSizeCalculator(CurrentLayout.SPEC));
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sekaiga commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
sekaiga commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072092322
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1070807639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1086849029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "b4f82659a528abea9ebbdc872bd8e59a80d9aa2a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b4f82659a528abea9ebbdc872bd8e59a80d9aa2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066)
* b4f82659a528abea9ebbdc872bd8e59a80d9aa2a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1071895085
@sekaiga please format the description appropriately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072073702
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sekaiga commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
sekaiga commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072073070
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1080139809
@sekaiga can you please rebase master ? this is a small fix we can land for 0.11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1070807639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072073702
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1070871135
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ca61208eb5006ee7ad31912f5a6a6d18c5efd46 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1086849716
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "b4f82659a528abea9ebbdc872bd8e59a80d9aa2a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7790",
"triggerID" : "b4f82659a528abea9ebbdc872bd8e59a80d9aa2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066)
* b4f82659a528abea9ebbdc872bd8e59a80d9aa2a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7790)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1070809957
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ca61208eb5006ee7ad31912f5a6a6d18c5efd46 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072094780
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1086870058
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "b4f82659a528abea9ebbdc872bd8e59a80d9aa2a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7790",
"triggerID" : "b4f82659a528abea9ebbdc872bd8e59a80d9aa2a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4f82659a528abea9ebbdc872bd8e59a80d9aa2a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7790)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1070807639
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ca61208eb5006ee7ad31912f5a6a6d18c5efd46 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072094780
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072092322",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7069) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072074727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1075859852
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1070809957
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ca61208eb5006ee7ad31912f5a6a6d18c5efd46 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1071895085
@sekaiga please format the description appropriately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#discussion_r829665766
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java
##########
@@ -92,6 +92,7 @@ public static long getObjectSize(Object obj) throws UnsupportedOperationExceptio
private final Set<Object> alreadyVisited = Collections.newSetFromMap(new IdentityHashMap<>());
private final Deque<Object> pending = new ArrayDeque<>(64);
private long size;
+ private static final ThreadLocal<ObjectSizeCalculator> objectSizeCalculator = ThreadLocal.withInitial(() -> new ObjectSizeCalculator(CurrentLayout.SPEC));
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a change in pull request #5060: [HUDI-3652] use threadlocal to decrease ObjectSizeCalculator memory use
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on a change in pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#discussion_r829607531
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java
##########
@@ -92,6 +92,7 @@ public static long getObjectSize(Object obj) throws UnsupportedOperationExceptio
private final Set<Object> alreadyVisited = Collections.newSetFromMap(new IdentityHashMap<>());
private final Deque<Object> pending = new ArrayDeque<>(64);
private long size;
+ private static final ThreadLocal<ObjectSizeCalculator> objectSizeCalculator = ThreadLocal.withInitial(() -> new ObjectSizeCalculator(CurrentLayout.SPEC));
Review comment:
Let's bubble this up to the top of the declarations list (where all the static members are)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5060: [HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5060:
URL: https://github.com/apache/hudi/pull/5060#issuecomment-1072074727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7031",
"triggerID" : "2ca61208eb5006ee7ad31912f5a6a6d18c5efd46",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "1072073070",
"triggerType" : "MANUAL"
}, {
"hash" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066",
"triggerID" : "0528eca3ca3e24b61b8831063716fa9cb83d93cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 0528eca3ca3e24b61b8831063716fa9cb83d93cb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7066)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org