[PR] cmake:replenish flatbuffers system/gprof app CMake build [nuttx-apps]

["xuxin930 (via GitHub)" <gi...@apache.org>]

xuxin930 opened a new pull request, #2779:
URL: https://github.com/apache/nuttx-apps/pull/2779

   ## Summary
   
   Added flatbuffers cmake scripts
   Added system/gprof cmake scripts
   
   ## Impact
   No impact on the past
   
   ## Testing
   
   ci build 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] cmake:replenish flatbuffers system/gprof app CMake build [nuttx-apps]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #2779:
URL: https://github.com/apache/nuttx-apps/pull/2779#issuecomment-2439809814

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   **No, this PR does not meet the NuttX requirements.**
   
   Here's why and how to improve it:
   
   * **Insufficient Summary:**
       * **Missing "Why":** The summary lacks a clear explanation of *why* these changes are necessary. Are these new features being added? Are existing functionalities being improved?  What problems do these additions solve? 
       * **Missing Details:**  
           * "Added flatbuffers cmake scripts" is too vague. Which components utilize flatbuffers? How are these scripts integrated? 
           * Similarly, specify which parts of the system use gprof and how the new CMake scripts are incorporated.
   * **Incomplete Impact Assessment:**
       * **"No impact on the past" is not a valid assessment.** While the changes might not directly break existing code, consider potential side effects:
           * **Build System:** Do these new CMake scripts introduce new dependencies or change the build process for other components?
           * **Configuration:** Do users need to be aware of any new configuration options or settings related to flatbuffers or gprof? 
   * **Insufficient Testing Information:**
       * **"ci build" is not descriptive enough.** Specify:
           * **Host Details:** Which CI platforms and configurations were used (OS, compiler versions)?
           * **Target Details:**  On which architectures and boards were the builds tested?
       * **Missing Logs:** Provide snippets of relevant log output demonstrating the successful integration of flatbuffers and gprof. 
   
   **To improve this PR:**
   
   1. **Expand the Summary:** Clearly articulate the motivation behind these additions. Provide specific details about what has been changed and how.
   2. **Thoroughly Assess Impact:**  Systematically analyze the potential impact on users, the build process, hardware, documentation, security, and compatibility. 
   3. **Provide Detailed Testing Information:** Include specific details about your testing environment (both host and target) and share relevant log excerpts showcasing the successful integration and functionality of your changes. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] cmake:replenish flatbuffers system/gprof app CMake build [nuttx-apps]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #2779:
URL: https://github.com/apache/nuttx-apps/pull/2779


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org