[GitHub] [echarts] pissang commented on a diff in pull request #16947: feat(axis): provide splitLine.showMinLine and splitLine.showMaxLine. …

[GitBox <gi...@apache.org>]

pissang commented on code in PR #16947:
URL: https://github.com/apache/echarts/pull/16947#discussion_r859465493


##########
src/coord/Axis.ts:
##########
@@ -193,6 +193,13 @@ class Axis {
             this, ticksCoords, alignWithLabel, opt.clamp
         );
 
+        if (tickModel.get('showMinLine') === false) {

Review Comment:
   Modifying the result here will affect the display of labels and ticks lines. If only splitLine will be affected, it's better to do it in the render function https://github.com/apache/echarts/blob/cc0ebd2845781021cb05287fded7c94b26174619/src/component/axis/CartesianAxisView.ts#L141



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org