You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2010/11/11 17:15:16 UTC

[jira] Created: (MYFACES-2970) f:convertNumber conversion is not symmetric when currencyCode and currencySymbol are used

f:convertNumber conversion is not symmetric when currencyCode and currencySymbol are used
-----------------------------------------------------------------------------------------

                 Key: MYFACES-2970
                 URL: https://issues.apache.org/jira/browse/MYFACES-2970
             Project: MyFaces Core
          Issue Type: Bug
          Components: JSR-127, JSR-252, JSR-314
    Affects Versions: 2.0.2, 1.2.9, 1.1.8
            Reporter: Leonardo Uribe
            Assignee: Leonardo Uribe


Checking some code on myfaces commons, I notice f:convertNumber conversion is not symmetric when currencyCode and currencySymbol are used.

The problem can be seen when an application has one locale, but you require the field read a different currency for the default one. The solution is call formatCurrency too from getAsObject method.

It seems MyFaces implements the javadoc description for NumberConverter without think carefully if that description was complete or not. On getAsString it says:

"...If the type is set to currency, it is also possible to configure the currency symbol to be used, using either the currencyCode or currencySymbol properties. If both are set, the value for currencyCode takes precedence on a JDK 1.4 (or later) JVM; otherwise, the value for currencySymbol takes precedence...."

But if that so, and getAsObject receive the string formatted with the previous rule, it should take into account the configured currencyCode/currencySymbol.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MYFACES-2970) f:convertNumber conversion is not symmetric when currencyCode and currencySymbol are used

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-2970.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.3-SNAPSHOT
                   1.2.10-SNAPSHOT
                   1.1.9-SNAPSHOT

> f:convertNumber conversion is not symmetric when currencyCode and currencySymbol are used
> -----------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2970
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2970
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-127, JSR-252, JSR-314
>    Affects Versions: 1.1.8, 1.2.9, 2.0.2
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.9-SNAPSHOT, 1.2.10-SNAPSHOT, 2.0.3-SNAPSHOT
>
>
> Checking some code on myfaces commons, I notice f:convertNumber conversion is not symmetric when currencyCode and currencySymbol are used.
> The problem can be seen when an application has one locale, but you require the field read a different currency for the default one. The solution is call formatCurrency too from getAsObject method.
> It seems MyFaces implements the javadoc description for NumberConverter without think carefully if that description was complete or not. On getAsString it says:
> "...If the type is set to currency, it is also possible to configure the currency symbol to be used, using either the currencyCode or currencySymbol properties. If both are set, the value for currencyCode takes precedence on a JDK 1.4 (or later) JVM; otherwise, the value for currencySymbol takes precedence...."
> But if that so, and getAsObject receive the string formatted with the previous rule, it should take into account the configured currencyCode/currencySymbol.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.