[GitHub] piiswrong commented on a change in pull request #7352: add Sequential compatibility to rnn layers

[gi...@git.apache.org]

piiswrong commented on a change in pull request #7352: add Sequential compatibility to rnn layers
URL: https://github.com/apache/incubator-mxnet/pull/7352#discussion_r131535006
 
 

 ##########
 File path: python/mxnet/gluon/rnn/rnn_layer.py
 ##########
 @@ -151,10 +151,52 @@ def begin_state(self, batch_size=0, func=ndarray.zeros, **kwargs):
             states.append(func(name='%sh0_%d'%(self.prefix, i), **info))
         return states
 
-    def forward(self, inputs, states):
+    def forward(self, inputs, states=None):
+        """Performs the RNN transformation for all time steps.
 
 Review comment:
   This is not visible. Put it in the class doc string of each layer
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services