You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2011/08/02 05:08:27 UTC

[jira] [Created] (MYFACES-3255) UICommand.queueEvent description changed since 2.0

UICommand.queueEvent description changed since 2.0
--------------------------------------------------

                 Key: MYFACES-3255
                 URL: https://issues.apache.org/jira/browse/MYFACES-3255
             Project: MyFaces Core
          Issue Type: Bug
            Reporter: Leonardo Uribe
            Assignee: Leonardo Uribe


Checking some javadoc for JSF 2.2 "viewAction", I notice our implementation of UICommand.queueEvent does not match with the documentation since JSF 2.0.

Before:

public void queueEvent(FacesEvent e)

    Intercept queueEvent and, for ActionEvents, mark the phaseId for the event to be PhaseId.APPLY_REQUEST_VALUES if the immediate flag is true, PhaseId.INVOKE_APPLICATION otherwise.

After:

public void queueEvent(FacesEvent e)

    Intercept queueEvent and take the following action. If the event is an ActionEvent, obtain the UIComponent instance from the event. If the component is an ActionSource obtain the value of its "immediate" property. If it is true, mark the phaseId for the event to be PhaseId.APPLY_REQUEST_VALUES otherwise, mark the phaseId to be PhaseId.INVOKE_APPLICATION. The event must be passed on to super.queueEvent() before returning from this method.


Tracking this one I found this issue:

http://java.net/jira/browse/JAVASERVERFACES-622

Since it was added after 1.2 rev A and before 2.0, myfaces code still does what the spec says since 1.2. Anyway,  we should change MyFaces code to follow the javadoc description.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (MYFACES-3255) UICommand.queueEvent description changed since 2.0

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-3255.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.2
                   2.0.8
                   1.2.11

> UICommand.queueEvent description changed since 2.0
> --------------------------------------------------
>
>                 Key: MYFACES-3255
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3255
>             Project: MyFaces Core
>          Issue Type: Bug
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 1.2.11, 2.0.8, 2.1.2
>
>
> Checking some javadoc for JSF 2.2 "viewAction", I notice our implementation of UICommand.queueEvent does not match with the documentation since JSF 2.0.
> Before:
> public void queueEvent(FacesEvent e)
>     Intercept queueEvent and, for ActionEvents, mark the phaseId for the event to be PhaseId.APPLY_REQUEST_VALUES if the immediate flag is true, PhaseId.INVOKE_APPLICATION otherwise.
> After:
> public void queueEvent(FacesEvent e)
>     Intercept queueEvent and take the following action. If the event is an ActionEvent, obtain the UIComponent instance from the event. If the component is an ActionSource obtain the value of its "immediate" property. If it is true, mark the phaseId for the event to be PhaseId.APPLY_REQUEST_VALUES otherwise, mark the phaseId to be PhaseId.INVOKE_APPLICATION. The event must be passed on to super.queueEvent() before returning from this method.
> Tracking this one I found this issue:
> http://java.net/jira/browse/JAVASERVERFACES-622
> Since it was added after 1.2 rev A and before 2.0, myfaces code still does what the spec says since 1.2. Anyway,  we should change MyFaces code to follow the javadoc description.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira