You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Brian Geffon <br...@apache.org> on 2012/01/27 07:16:52 UTC
TS-1035: Ready to commit? Comments Please.
Hi All,
While trying to use ATS with a very large number of ports (350+) ATS will
segfault as a result of running out of event threads with no type of check
or assertion. The patch submitted to fix this bug solves that problem,
additionally, it allows MAX_EVENT_THREADS and MAX_THREADS_PER_TYPE to be
configured via ./configure. Furthermore, to allow trafficmanager to be able
to pass a full list of file descriptors to traffic_server I had to expose
ARG_MAX via get conf so that local manager could fully generate the -A file
descriptor list.
This is a relatively small patch; however, I was hoping I could get a few
eyes to check it out because I don't have much experience with
autoconf/automake and I wanted to make sure everyone is okay with the
approach.
Thanks.
Brian
https://issues.apache.org/jira/browse/TS-1035
Re: TS-1035: Ready to commit? Comments Please.
Posted by Brian Geffon <br...@gmail.com>.
Ok, I see. My mistake I'll make sure to do an svn up before asking for
feedback next time :) I'll get a new patch asap.
Brian
On Jan 26, 2012, at 10:51 PM, "Alan M. Carroll"
<am...@network-geographics.com> wrote:
> Without looking at the patch, you'll have a problem in that there is no longer a -A argument. The proxy port descriptors are passed to Server via the --httpport option. Check your patch against trunk.
>
> I'll have to check if you cleaned up the string length / offset calculation which is done horribly for your situation, doing a strlen on the entire option for every port.
>
> Friday, January 27, 2012, 12:16:52 AM, you wrote:
>
>> Hi All,
>
>> While trying to use ATS with a very large number of ports (350+) ATS will
>> segfault as a result of running out of event threads with no type of check
>> or assertion. The patch submitted to fix this bug solves that problem,
>> additionally, it allows MAX_EVENT_THREADS and MAX_THREADS_PER_TYPE to be
>> configured via ./configure. Furthermore, to allow trafficmanager to be able
>> to pass a full list of file descriptors to traffic_server I had to expose
>> ARG_MAX via get conf so that local manager could fully generate the -A file
>> descriptor list.
>
>> This is a relatively small patch; however, I was hoping I could get a few
>> eyes to check it out because I don't have much experience with
>> autoconf/automake and I wanted to make sure everyone is okay with the
>> approach.
>
>> Thanks.
>> Brian
>
>> https://issues.apache.org/jira/browse/TS-1035
>
Re: TS-1035: Ready to commit? Comments Please.
Posted by "Alan M. Carroll" <am...@network-geographics.com>.
Friday, January 27, 2012, 12:55:40 AM, you wrote:
> My patch was developed and tested against trunk. I'm a little confused because the -A option was working 2 days ago, is there a new commit that I missed? Was it your TS-1077?
Yes.
Re: TS-1035: Ready to commit? Comments Please.
Posted by Brian Geffon <bg...@linkedin.com>.
My patch was developed and tested against trunk. I'm a little confused because the -A option was working 2 days ago, is there a new commit that I missed? Was it your TS-1077?
Brian
On Jan 26, 2012, at 10:51 PM, "Alan M. Carroll" <am...@network-geographics.com> wrote:
> Without looking at the patch, you'll have a problem in that there is no longer a -A argument. The proxy port descriptors are passed to Server via the --httpport option. Check your patch against trunk.
>
> I'll have to check if you cleaned up the string length / offset calculation which is done horribly for your situation, doing a strlen on the entire option for every port.
>
> Friday, January 27, 2012, 12:16:52 AM, you wrote:
>
>> Hi All,
>
>> While trying to use ATS with a very large number of ports (350+) ATS will
>> segfault as a result of running out of event threads with no type of check
>> or assertion. The patch submitted to fix this bug solves that problem,
>> additionally, it allows MAX_EVENT_THREADS and MAX_THREADS_PER_TYPE to be
>> configured via ./configure. Furthermore, to allow trafficmanager to be able
>> to pass a full list of file descriptors to traffic_server I had to expose
>> ARG_MAX via get conf so that local manager could fully generate the -A file
>> descriptor list.
>
>> This is a relatively small patch; however, I was hoping I could get a few
>> eyes to check it out because I don't have much experience with
>> autoconf/automake and I wanted to make sure everyone is okay with the
>> approach.
>
>> Thanks.
>> Brian
>
>> https://issues.apache.org/jira/browse/TS-1035
>
Re: TS-1035: Ready to commit? Comments Please.
Posted by "Alan M. Carroll" <am...@network-geographics.com>.
Without looking at the patch, you'll have a problem in that there is no longer a -A argument. The proxy port descriptors are passed to Server via the --httpport option. Check your patch against trunk.
I'll have to check if you cleaned up the string length / offset calculation which is done horribly for your situation, doing a strlen on the entire option for every port.
Friday, January 27, 2012, 12:16:52 AM, you wrote:
> Hi All,
> While trying to use ATS with a very large number of ports (350+) ATS will
> segfault as a result of running out of event threads with no type of check
> or assertion. The patch submitted to fix this bug solves that problem,
> additionally, it allows MAX_EVENT_THREADS and MAX_THREADS_PER_TYPE to be
> configured via ./configure. Furthermore, to allow trafficmanager to be able
> to pass a full list of file descriptors to traffic_server I had to expose
> ARG_MAX via get conf so that local manager could fully generate the -A file
> descriptor list.
> This is a relatively small patch; however, I was hoping I could get a few
> eyes to check it out because I don't have much experience with
> autoconf/automake and I wanted to make sure everyone is okay with the
> approach.
> Thanks.
> Brian
> https://issues.apache.org/jira/browse/TS-1035