[jira] [Comment Edited] (MINIFICPP-953) Review the code for proper integral type usage

["Mr TheSegfault (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894000#comment-16894000 ] 

Mr TheSegfault edited comment on MINIFICPP-953 at 7/26/19 5:18 PM:
-------------------------------------------------------------------

This particular ticket seems like one which will outlive the rest. I don't think we should go scouring code looking for this but rather keep this open and use it to track the efforts as they arise. I have seen tickets like this from myself and [~aboda] , so I hope this doesn't get lost in time and is used to address these concerns over time – particularly to help with tracking


was (Author: phrocker):
This particular ticket seems like one which will outlive the rest. I don't think we should go scouring code looking for this but rather keep this open and use it to track the efforts as they arise. I have seen tickets like this from myself and [~aboda] , so I hope this doesn't get lost in time and is used to address these concerns over time.

> Review the code for proper integral type usage
> ----------------------------------------------
>
>                 Key: MINIFICPP-953
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-953
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Daniel Bakai
>            Priority: Major
>
> * There are many cases of improper narrowings, badly chosen integer types, unnoticed implicit casts and potential overflows
>  * These can cause bugs and are a huge potential security issue



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)