You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/03/21 00:24:42 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #3993: In
TableConfig, add checks for mandatory fields
codecov-io edited a comment on issue #3993: In TableConfig, add checks for mandatory fields
URL: https://github.com/apache/incubator-pinot/pull/3993#issuecomment-474986968
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=h1) Report
> Merging [#3993](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/d78a8075d64801b258d5634bbcb82121e5f3506f?src=pr&el=desc) will **decrease** coverage by `16.69%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/3993/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3993 +/- ##
============================================
- Coverage 67.17% 50.48% -16.7%
Complexity 4 4
============================================
Files 1032 1155 +123
Lines 51127 58088 +6961
Branches 7137 8046 +909
============================================
- Hits 34344 29325 -5019
- Misses 14431 26597 +12166
+ Partials 2352 2166 -186
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/pinot/common/config/TableConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhYmxlQ29uZmlnLmphdmE=) | `69.54% <100%> (-8.86%)` | `0 <0> (ø)` | |
| [...e/pinot/core/operator/blocks/EmptyFilterBlock.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvRW1wdHlGaWx0ZXJCbG9jay5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...lection/iterator/FloatSelectionColumnIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vaXRlcmF0b3IvRmxvYXRTZWxlY3Rpb25Db2x1bW5JdGVyYXRvci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...ot/minion/events/EventObserverFactoryRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXZlbnRzL0V2ZW50T2JzZXJ2ZXJGYWN0b3J5UmVnaXN0cnkuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...minion/executor/ConvertToRawIndexTaskExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3IuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...on/iterator/FloatArraySelectionColumnIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vaXRlcmF0b3IvRmxvYXRBcnJheVNlbGVjdGlvbkNvbHVtbkl0ZXJhdG9yLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...a/org/apache/pinot/minion/metrics/MinionMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [.../apache/pinot/minion/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...selection/iterator/IntSelectionColumnIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vaXRlcmF0b3IvSW50U2VsZWN0aW9uQ29sdW1uSXRlcmF0b3IuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...ection/iterator/DoubleSelectionColumnIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vaXRlcmF0b3IvRG91YmxlU2VsZWN0aW9uQ29sdW1uSXRlcmF0b3IuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [451 more](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=footer). Last update [d78a807...9bc06ed](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org