You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2024/10/14 09:56:21 UTC
Re: [PR] [SPARK-49957][SQL] Scala API for string validation functions [spark]
MaxGekk commented on code in PR #48454:
URL: https://github.com/apache/spark/pull/48454#discussion_r1799112657
##########
sql/api/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -3911,6 +3911,43 @@ object functions {
def encode(value: Column, charset: String): Column =
Column.fn("encode", value, lit(charset))
+ /**
+ * Returns true if the input is a valid UTF-8 string, otherwise returns false.
+ *
+ * @group string_funcs
+ * @since 4.0.0
+ */
+ def is_valid_utf8(str: Column): Column =
Review Comment:
You should follow naming conventions and use the camelCase style, see https://github.com/databricks/scala-style-guide?tab=readme-ov-file#naming-convention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org