You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/08 14:26:59 UTC

[GitHub] [hudi] leesf commented on a change in pull request #3944: [HUDI-2495] resolve inconsistent key generation for timestamp types b…

leesf commented on a change in pull request #3944:
URL: https://github.com/apache/hudi/pull/3944#discussion_r744774502



##########
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##########
@@ -539,6 +540,8 @@ public static Object convertValueForSpecificDataTypes(Schema fieldSchema, Object
   private static Object convertValueForAvroLogicalTypes(Schema fieldSchema, Object fieldValue) {
     if (fieldSchema.getLogicalType() == LogicalTypes.date()) {
       return LocalDate.ofEpochDay(Long.parseLong(fieldValue.toString()));
+    } else if (fieldSchema.getLogicalType() == LogicalTypes.timestampMicros()) {

Review comment:
       is there any tests to cover the case?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org