[jira] [Commented] (NIFI-4221) Print app startup in human-readable time

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100613#comment-16100613 ] 

ASF GitHub Bot commented on NIFI-4221:
--------------------------------------

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi/pull/2038

    NIFI-4221 - Print app startup in human-readable time

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi NIFI-4221

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2038.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2038
    
----
commit 93c66c513aeed3aad3aace3d890923a328893589
Author: Pierre Villard <pi...@gmail.com>
Date:   2017-07-25T19:27:49Z

    NIFI-4221 - Print app startup in human-readable time

----


> Print app startup in human-readable time
> ----------------------------------------
>
>                 Key: NIFI-4221
>                 URL: https://issues.apache.org/jira/browse/NIFI-4221
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.3.0
>            Reporter: Andy LoPresto
>            Assignee: Pierre Villard
>            Priority: Minor
>              Labels: logs, time
>
> Currently the application startup time is printed in nanoseconds in the app log. While this is very precise, because of the scale of these values, it can require mental math to detect delays or variance from the standard/average timing. I think it would be helpful to print a "human-readable" (i.e. broken out into larger units) start time alongside the nanosecond precision time: 
> {code}
> 2017-07-24 14:00:14,159 INFO [main] org.apache.nifi.NiFi Controller initialization took 15127377569 nanoseconds.
> {code}
> to:
> {code}
> 2017-07-24 14:00:14,159 INFO [main] org.apache.nifi.NiFi Controller initialization took 15127377569 nanoseconds (15 seconds).
> {code}
> While currently it's simply a matter of moving the decimal over the right number of places, some deployments on cloud systems (especially those with low entropy before NIFI-3313 was resolved) could take minutes to deploy. Being able to parse these values in meaningful dimensions at a glance is helpful. 
> Update: This is also the case with NAR unpacking time: {{2017-06-05 19:39:50,095 INFO [main] org.apache.nifi.nar.NarUnpacker NAR loading process took 11056718205 nanoseconds.}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)