You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Hadrian Zbarcea (JIRA)" <ji...@apache.org> on 2011/06/02 19:23:47 UTC

[jira] [Created] (CAMEL-4041) Use a FatalErrorHandler for exceptions thrown while handling another exception.

Use a FatalErrorHandler for exceptions thrown while handling another exception.
-------------------------------------------------------------------------------

                 Key: CAMEL-4041
                 URL: https://issues.apache.org/jira/browse/CAMEL-4041
             Project: Camel
          Issue Type: Improvement
          Components: camel-core
    Affects Versions: 2.7.1
            Reporter: Hadrian Zbarcea
            Assignee: Hadrian Zbarcea
             Fix For: 2.8.0


This is spawn out of CAMEL-4022 (see part of the discussion there).

If exceptions are thrown while an exception is handled, there is not much Camel can do to recover. We need a FatalErrorHander that can not be replaced by the user, which a simple and predictable behavior (at least logging).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4041) Use a FatalErrorHandler for exceptions thrown while handling another exception.

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046654#comment-13046654 ] 

Hadrian Zbarcea commented on CAMEL-4041:
----------------------------------------

I'd suggest fixing this in a few steps. First the core then spring and the rest (if anything else is affected). There's nothing worse than it is today if only the core is patched in a first step. That's why I created separate issues, and then with the duplicates we ended up with the confusion.

So what if we use this issue only for the core and CAMEL-4022 for the spring side?

> Use a FatalErrorHandler for exceptions thrown while handling another exception.
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-4041
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4041
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.7.1
>            Reporter: Hadrian Zbarcea
>            Assignee: Claus Ibsen
>             Fix For: 2.8.0
>
>
> This is spawn out of CAMEL-4022 (see part of the discussion there).
> If exceptions are thrown while an exception is handled, there is not much Camel can do to recover. We need a FatalErrorHander that can not be replaced by the user, which a simple and predictable behavior (at least logging).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CAMEL-4041) Use a FatalErrorHandler for exceptions thrown while handling another exception.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-4041.
--------------------------------

    Resolution: Fixed

There is now a FatalFallbackErrorHandler

> Use a FatalErrorHandler for exceptions thrown while handling another exception.
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-4041
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4041
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.7.1
>            Reporter: Hadrian Zbarcea
>            Assignee: Claus Ibsen
>             Fix For: 2.8.0
>
>
> This is spawn out of CAMEL-4022 (see part of the discussion there).
> If exceptions are thrown while an exception is handled, there is not much Camel can do to recover. We need a FatalErrorHander that can not be replaced by the user, which a simple and predictable behavior (at least logging).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (CAMEL-4041) Use a FatalErrorHandler for exceptions thrown while handling another exception.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reassigned CAMEL-4041:
----------------------------------

    Assignee: Claus Ibsen  (was: Hadrian Zbarcea)

> Use a FatalErrorHandler for exceptions thrown while handling another exception.
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-4041
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4041
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.7.1
>            Reporter: Hadrian Zbarcea
>            Assignee: Claus Ibsen
>             Fix For: 2.8.0
>
>
> This is spawn out of CAMEL-4022 (see part of the discussion there).
> If exceptions are thrown while an exception is handled, there is not much Camel can do to recover. We need a FatalErrorHander that can not be replaced by the user, which a simple and predictable behavior (at least logging).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4041) Use a FatalErrorHandler for exceptions thrown while handling another exception.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046719#comment-13046719 ] 

Claus Ibsen commented on CAMEL-4041:
------------------------------------

I get a pending for so the tests runs in spring as well. I will do a full build to ensure no side effects is introduced.

> Use a FatalErrorHandler for exceptions thrown while handling another exception.
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-4041
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4041
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.7.1
>            Reporter: Hadrian Zbarcea
>            Assignee: Claus Ibsen
>             Fix For: 2.8.0
>
>
> This is spawn out of CAMEL-4022 (see part of the discussion there).
> If exceptions are thrown while an exception is handled, there is not much Camel can do to recover. We need a FatalErrorHander that can not be replaced by the user, which a simple and predictable behavior (at least logging).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4041) Use a FatalErrorHandler for exceptions thrown while handling another exception.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046633#comment-13046633 ] 

Claus Ibsen commented on CAMEL-4041:
------------------------------------

Okay in the spring side it takes a bit more work to do as the error handlers is configured using refs and that indirection need a little adjustment for this new FatalErrorHandler to work properly.

> Use a FatalErrorHandler for exceptions thrown while handling another exception.
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-4041
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4041
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.7.1
>            Reporter: Hadrian Zbarcea
>            Assignee: Claus Ibsen
>             Fix For: 2.8.0
>
>
> This is spawn out of CAMEL-4022 (see part of the discussion there).
> If exceptions are thrown while an exception is handled, there is not much Camel can do to recover. We need a FatalErrorHander that can not be replaced by the user, which a simple and predictable behavior (at least logging).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4041) Use a FatalErrorHandler for exceptions thrown while handling another exception.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044251#comment-13044251 ] 

Claus Ibsen commented on CAMEL-4041:
------------------------------------

I would probably not name it FatalErrorHandler, but something like OnExceptionErrorHandler etc. to indicate its intention.

> Use a FatalErrorHandler for exceptions thrown while handling another exception.
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-4041
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4041
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.7.1
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>             Fix For: 2.8.0
>
>
> This is spawn out of CAMEL-4022 (see part of the discussion there).
> If exceptions are thrown while an exception is handled, there is not much Camel can do to recover. We need a FatalErrorHander that can not be replaced by the user, which a simple and predictable behavior (at least logging).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4041) Use a FatalErrorHandler for exceptions thrown while handling another exception.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046996#comment-13046996 ] 

Claus Ibsen commented on CAMEL-4041:
------------------------------------

Okay full tests 100% success. I gotta polish the patch a bit, but it looks good.

> Use a FatalErrorHandler for exceptions thrown while handling another exception.
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-4041
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4041
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.7.1
>            Reporter: Hadrian Zbarcea
>            Assignee: Claus Ibsen
>             Fix For: 2.8.0
>
>
> This is spawn out of CAMEL-4022 (see part of the discussion there).
> If exceptions are thrown while an exception is handled, there is not much Camel can do to recover. We need a FatalErrorHander that can not be replaced by the user, which a simple and predictable behavior (at least logging).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4041) Use a FatalErrorHandler for exceptions thrown while handling another exception.

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046656#comment-13046656 ] 

Claus Ibsen commented on CAMEL-4041:
------------------------------------

You cannot divide it like that. There are tests in both core + spring that only works in core. The tests is constructed to be 100% identical. Its just some logic needed to be adjusted in camel-core because Java DSL and XML DSL is building the route model a bit different (fluent builders VS JAXB).

I gotta run

> Use a FatalErrorHandler for exceptions thrown while handling another exception.
> -------------------------------------------------------------------------------
>
>                 Key: CAMEL-4041
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4041
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.7.1
>            Reporter: Hadrian Zbarcea
>            Assignee: Claus Ibsen
>             Fix For: 2.8.0
>
>
> This is spawn out of CAMEL-4022 (see part of the discussion there).
> If exceptions are thrown while an exception is handled, there is not much Camel can do to recover. We need a FatalErrorHander that can not be replaced by the user, which a simple and predictable behavior (at least logging).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira