You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/06 02:33:50 UTC

[GitHub] [kafka] guozhangwang commented on a change in pull request #8820: KAFKA-10097: Internalize checkpoint data

guozhangwang commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436229822



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -107,6 +107,9 @@
     private boolean commitNeeded = false;
     private boolean commitRequested = false;
 
+    private boolean checkpointNeeded = false;

Review comment:
       Do we need two parameters here? Could we still just use one `Map<TopicPartition, Long> checkpoint`, and then in `writeCheckpointIfNeed` if it is not null write it and then set it to null.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org