You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Rahul Akolkar <ra...@gmail.com> on 2010/04/14 01:18:49 UTC

Re: changes-plugin version (was: svn commit: r933811)

Thanks for doing this Niall. One comment below ...

On Tue, Apr 13, 2010 at 7:11 PM,  <ni...@apache.org> wrote:
> Author: niallp
> Date: Tue Apr 13 23:11:26 2010
> New Revision: 933811
>
> URL: http://svn.apache.org/viewvc?rev=933811&view=rev
> Log:
> Move/rename "xdocs" directory to standard m2 "src/site/xdoc"
>
> Added:
>    commons/proper/scxml/branches/J6/src/changes/
>    commons/proper/scxml/branches/J6/src/changes/changes.xml
>      - copied unchanged from r933806, commons/proper/scxml/branches/J6/xdocs/changes.xml
>    commons/proper/scxml/branches/J6/src/site/fml/
>    commons/proper/scxml/branches/J6/src/site/fml/faq.fml
>      - copied unchanged from r933806, commons/proper/scxml/branches/J6/xdocs/faq.fml
>    commons/proper/scxml/branches/J6/src/site/xdoc/
>      - copied from r933806, commons/proper/scxml/branches/J6/xdocs/
> Removed:
>    commons/proper/scxml/branches/J6/src/site/xdoc/changes.xml
>    commons/proper/scxml/branches/J6/src/site/xdoc/faq.fml
>    commons/proper/scxml/branches/J6/src/site/xdoc/images/
>    commons/proper/scxml/branches/J6/src/site/xdoc/style/
>    commons/proper/scxml/branches/J6/xdocs/
> Modified:
>    commons/proper/scxml/branches/J6/pom.xml
>    commons/proper/scxml/branches/J6/src/assembly/src.xml
>
> Modified: commons/proper/scxml/branches/J6/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/pom.xml?rev=933811&r1=933810&r2=933811&view=diff
> ==============================================================================
> --- commons/proper/scxml/branches/J6/pom.xml (original)
> +++ commons/proper/scxml/branches/J6/pom.xml Tue Apr 13 23:11:26 2010
> @@ -280,9 +280,9 @@
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-changes-plugin</artifactId>
> -        <version>2.1</version>
> +        <version>2.0</version>
<snip/>

Downgrade?

-Rahul


>         <configuration>
> -          <xmlPath>${basedir}/xdocs/changes.xml</xmlPath>
> +          <xmlPath>${basedir}/src/changes/changes.xml</xmlPath>
>           <issueLinkTemplate>%URL%/%ISSUE%</issueLinkTemplate>
>         </configuration>
>         <reportSets>
>
> Modified: commons/proper/scxml/branches/J6/src/assembly/src.xml
> URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/src/assembly/src.xml?rev=933811&r1=933810&r2=933811&view=diff
> ==============================================================================
> --- commons/proper/scxml/branches/J6/src/assembly/src.xml (original)
> +++ commons/proper/scxml/branches/J6/src/assembly/src.xml Tue Apr 13 23:11:26 2010
> @@ -27,11 +27,8 @@
>                 <include>build.properties.sample</include>
>                 <include>build.xml</include>
>                 <include>LICENSE.txt</include>
> -                <include>maven.xml</include>
>                 <include>NOTICE.txt</include>
>                 <include>pom.xml</include>
> -                <include>project.properties</include>
> -                <include>project.xml</include>
>                 <include>RELEASE-NOTES.txt</include>
>                 <include>scxml-asl-header.txt</include>
>                 <include>scxml-checks.xml</include>
> @@ -40,8 +37,5 @@
>         <fileSet>
>             <directory>src</directory>
>         </fileSet>
> -        <fileSet>
> -            <directory>xdocs</directory>
> -        </fileSet>
>     </fileSets>
>  </assembly>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: changes-plugin version (was: svn commit: r933811)

Posted by Niall Pemberton <ni...@gmail.com>.
On Wed, Apr 14, 2010 at 1:02 AM, sebb <se...@gmail.com> wrote:
> On 14/04/2010, Niall Pemberton <ni...@gmail.com> wrote:
>> On Wed, Apr 14, 2010 at 12:18 AM, Rahul Akolkar <ra...@gmail.com> wrote:
>>  > Thanks for doing this Niall. One comment below ...
>>  >
>>  > On Tue, Apr 13, 2010 at 7:11 PM,  <ni...@apache.org> wrote:
>>  >> Author: niallp
>>  >> Date: Tue Apr 13 23:11:26 2010
>>  >> New Revision: 933811
>>  >>
>>  >> URL: http://svn.apache.org/viewvc?rev=933811&view=rev
>>  >> Log:
>>  >> Move/rename "xdocs" directory to standard m2 "src/site/xdoc"
>>  >>
>>  >> Added:
>>  >>    commons/proper/scxml/branches/J6/src/changes/
>>  >>    commons/proper/scxml/branches/J6/src/changes/changes.xml
>>  >>      - copied unchanged from r933806, commons/proper/scxml/branches/J6/xdocs/changes.xml
>>  >>    commons/proper/scxml/branches/J6/src/site/fml/
>>  >>    commons/proper/scxml/branches/J6/src/site/fml/faq.fml
>>  >>      - copied unchanged from r933806, commons/proper/scxml/branches/J6/xdocs/faq.fml
>>  >>    commons/proper/scxml/branches/J6/src/site/xdoc/
>>  >>      - copied from r933806, commons/proper/scxml/branches/J6/xdocs/
>>  >> Removed:
>>  >>    commons/proper/scxml/branches/J6/src/site/xdoc/changes.xml
>>  >>    commons/proper/scxml/branches/J6/src/site/xdoc/faq.fml
>>  >>    commons/proper/scxml/branches/J6/src/site/xdoc/images/
>>  >>    commons/proper/scxml/branches/J6/src/site/xdoc/style/
>>  >>    commons/proper/scxml/branches/J6/xdocs/
>>  >> Modified:
>>  >>    commons/proper/scxml/branches/J6/pom.xml
>>  >>    commons/proper/scxml/branches/J6/src/assembly/src.xml
>>  >>
>>  >> Modified: commons/proper/scxml/branches/J6/pom.xml
>>  >> URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/pom.xml?rev=933811&r1=933810&r2=933811&view=diff
>>  >> ==============================================================================
>>  >> --- commons/proper/scxml/branches/J6/pom.xml (original)
>>  >> +++ commons/proper/scxml/branches/J6/pom.xml Tue Apr 13 23:11:26 2010
>>  >> @@ -280,9 +280,9 @@
>>  >>       <plugin>
>>  >>         <groupId>org.apache.maven.plugins</groupId>
>>  >>         <artifactId>maven-changes-plugin</artifactId>
>>  >> -        <version>2.1</version>
>>  >> +        <version>2.0</version>
>>  > <snip/>
>>  >
>>  > Downgrade?
>>
>>
>> Yes later versions of don't accept html markup - so this produces an
>>  empty report with 2.1 - see:
>>
>>  http://commons.apache.org/scxml/changes-report.html
>>
>>  Downgrading allowed the report to be produced OK. If you want to
>>  upgrade to a later version then you'll need to remove the markup from
>>  the changes.xml
>
> May I request that this info is documented in the pom?

You can but its not something I'm going to do. My only interest was
moving the changes.xml out of the xdoc directory and testing that it
still worked. Theres quite a few components that are on the 2.0
version of the changes plugin and my guess is that at least a few will
have the same issue if they upgrade. If you want to document it then
go for it.

Niall

> Otherwise, the problem (and question) may well recur ...
>
>>
>>  Niall
>>
>>
>>  > -Rahul
>>  >
>>  >
>>  >>         <configuration>
>>  >> -          <xmlPath>${basedir}/xdocs/changes.xml</xmlPath>
>>  >> +          <xmlPath>${basedir}/src/changes/changes.xml</xmlPath>
>>  >>           <issueLinkTemplate>%URL%/%ISSUE%</issueLinkTemplate>
>>  >>         </configuration>
>>  >>         <reportSets>
>>  >>
>>  >> Modified: commons/proper/scxml/branches/J6/src/assembly/src.xml
>>  >> URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/src/assembly/src.xml?rev=933811&r1=933810&r2=933811&view=diff
>>  >> ==============================================================================
>>  >> --- commons/proper/scxml/branches/J6/src/assembly/src.xml (original)
>>  >> +++ commons/proper/scxml/branches/J6/src/assembly/src.xml Tue Apr 13 23:11:26 2010
>>  >> @@ -27,11 +27,8 @@
>>  >>                 <include>build.properties.sample</include>
>>  >>                 <include>build.xml</include>
>>  >>                 <include>LICENSE.txt</include>
>>  >> -                <include>maven.xml</include>
>>  >>                 <include>NOTICE.txt</include>
>>  >>                 <include>pom.xml</include>
>>  >> -                <include>project.properties</include>
>>  >> -                <include>project.xml</include>
>>  >>                 <include>RELEASE-NOTES.txt</include>
>>  >>                 <include>scxml-asl-header.txt</include>
>>  >>                 <include>scxml-checks.xml</include>
>>  >> @@ -40,8 +37,5 @@
>>  >>         <fileSet>
>>  >>             <directory>src</directory>
>>  >>         </fileSet>
>>  >> -        <fileSet>
>>  >> -            <directory>xdocs</directory>
>>  >> -        </fileSet>
>>  >>     </fileSets>
>>  >>  </assembly>
>>
>>  ---------------------------------------------------------------------
>>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>  For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: changes-plugin version (was: svn commit: r933811)

Posted by sebb <se...@gmail.com>.
On 14/04/2010, Niall Pemberton <ni...@gmail.com> wrote:
> On Wed, Apr 14, 2010 at 12:18 AM, Rahul Akolkar <ra...@gmail.com> wrote:
>  > Thanks for doing this Niall. One comment below ...
>  >
>  > On Tue, Apr 13, 2010 at 7:11 PM,  <ni...@apache.org> wrote:
>  >> Author: niallp
>  >> Date: Tue Apr 13 23:11:26 2010
>  >> New Revision: 933811
>  >>
>  >> URL: http://svn.apache.org/viewvc?rev=933811&view=rev
>  >> Log:
>  >> Move/rename "xdocs" directory to standard m2 "src/site/xdoc"
>  >>
>  >> Added:
>  >>    commons/proper/scxml/branches/J6/src/changes/
>  >>    commons/proper/scxml/branches/J6/src/changes/changes.xml
>  >>      - copied unchanged from r933806, commons/proper/scxml/branches/J6/xdocs/changes.xml
>  >>    commons/proper/scxml/branches/J6/src/site/fml/
>  >>    commons/proper/scxml/branches/J6/src/site/fml/faq.fml
>  >>      - copied unchanged from r933806, commons/proper/scxml/branches/J6/xdocs/faq.fml
>  >>    commons/proper/scxml/branches/J6/src/site/xdoc/
>  >>      - copied from r933806, commons/proper/scxml/branches/J6/xdocs/
>  >> Removed:
>  >>    commons/proper/scxml/branches/J6/src/site/xdoc/changes.xml
>  >>    commons/proper/scxml/branches/J6/src/site/xdoc/faq.fml
>  >>    commons/proper/scxml/branches/J6/src/site/xdoc/images/
>  >>    commons/proper/scxml/branches/J6/src/site/xdoc/style/
>  >>    commons/proper/scxml/branches/J6/xdocs/
>  >> Modified:
>  >>    commons/proper/scxml/branches/J6/pom.xml
>  >>    commons/proper/scxml/branches/J6/src/assembly/src.xml
>  >>
>  >> Modified: commons/proper/scxml/branches/J6/pom.xml
>  >> URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/pom.xml?rev=933811&r1=933810&r2=933811&view=diff
>  >> ==============================================================================
>  >> --- commons/proper/scxml/branches/J6/pom.xml (original)
>  >> +++ commons/proper/scxml/branches/J6/pom.xml Tue Apr 13 23:11:26 2010
>  >> @@ -280,9 +280,9 @@
>  >>       <plugin>
>  >>         <groupId>org.apache.maven.plugins</groupId>
>  >>         <artifactId>maven-changes-plugin</artifactId>
>  >> -        <version>2.1</version>
>  >> +        <version>2.0</version>
>  > <snip/>
>  >
>  > Downgrade?
>
>
> Yes later versions of don't accept html markup - so this produces an
>  empty report with 2.1 - see:
>
>  http://commons.apache.org/scxml/changes-report.html
>
>  Downgrading allowed the report to be produced OK. If you want to
>  upgrade to a later version then you'll need to remove the markup from
>  the changes.xml

May I request that this info is documented in the pom?

Otherwise, the problem (and question) may well recur ...

>
>  Niall
>
>
>  > -Rahul
>  >
>  >
>  >>         <configuration>
>  >> -          <xmlPath>${basedir}/xdocs/changes.xml</xmlPath>
>  >> +          <xmlPath>${basedir}/src/changes/changes.xml</xmlPath>
>  >>           <issueLinkTemplate>%URL%/%ISSUE%</issueLinkTemplate>
>  >>         </configuration>
>  >>         <reportSets>
>  >>
>  >> Modified: commons/proper/scxml/branches/J6/src/assembly/src.xml
>  >> URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/src/assembly/src.xml?rev=933811&r1=933810&r2=933811&view=diff
>  >> ==============================================================================
>  >> --- commons/proper/scxml/branches/J6/src/assembly/src.xml (original)
>  >> +++ commons/proper/scxml/branches/J6/src/assembly/src.xml Tue Apr 13 23:11:26 2010
>  >> @@ -27,11 +27,8 @@
>  >>                 <include>build.properties.sample</include>
>  >>                 <include>build.xml</include>
>  >>                 <include>LICENSE.txt</include>
>  >> -                <include>maven.xml</include>
>  >>                 <include>NOTICE.txt</include>
>  >>                 <include>pom.xml</include>
>  >> -                <include>project.properties</include>
>  >> -                <include>project.xml</include>
>  >>                 <include>RELEASE-NOTES.txt</include>
>  >>                 <include>scxml-asl-header.txt</include>
>  >>                 <include>scxml-checks.xml</include>
>  >> @@ -40,8 +37,5 @@
>  >>         <fileSet>
>  >>             <directory>src</directory>
>  >>         </fileSet>
>  >> -        <fileSet>
>  >> -            <directory>xdocs</directory>
>  >> -        </fileSet>
>  >>     </fileSets>
>  >>  </assembly>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: changes-plugin version (was: svn commit: r933811)

Posted by Rahul Akolkar <ra...@gmail.com>.
On Tue, Apr 13, 2010 at 7:37 PM, Niall Pemberton
<ni...@gmail.com> wrote:
> On Wed, Apr 14, 2010 at 12:18 AM, Rahul Akolkar <ra...@gmail.com> wrote:
>> Thanks for doing this Niall. One comment below ...
>>
>> On Tue, Apr 13, 2010 at 7:11 PM,  <ni...@apache.org> wrote:
>>> Author: niallp
>>> Date: Tue Apr 13 23:11:26 2010
>>> New Revision: 933811
>>>
>>> URL: http://svn.apache.org/viewvc?rev=933811&view=rev
>>> Log:
>>> Move/rename "xdocs" directory to standard m2 "src/site/xdoc"
>>>
>>> Added:
>>>    commons/proper/scxml/branches/J6/src/changes/
>>>    commons/proper/scxml/branches/J6/src/changes/changes.xml
>>>      - copied unchanged from r933806, commons/proper/scxml/branches/J6/xdocs/changes.xml
>>>    commons/proper/scxml/branches/J6/src/site/fml/
>>>    commons/proper/scxml/branches/J6/src/site/fml/faq.fml
>>>      - copied unchanged from r933806, commons/proper/scxml/branches/J6/xdocs/faq.fml
>>>    commons/proper/scxml/branches/J6/src/site/xdoc/
>>>      - copied from r933806, commons/proper/scxml/branches/J6/xdocs/
>>> Removed:
>>>    commons/proper/scxml/branches/J6/src/site/xdoc/changes.xml
>>>    commons/proper/scxml/branches/J6/src/site/xdoc/faq.fml
>>>    commons/proper/scxml/branches/J6/src/site/xdoc/images/
>>>    commons/proper/scxml/branches/J6/src/site/xdoc/style/
>>>    commons/proper/scxml/branches/J6/xdocs/
>>> Modified:
>>>    commons/proper/scxml/branches/J6/pom.xml
>>>    commons/proper/scxml/branches/J6/src/assembly/src.xml
>>>
>>> Modified: commons/proper/scxml/branches/J6/pom.xml
>>> URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/pom.xml?rev=933811&r1=933810&r2=933811&view=diff
>>> ==============================================================================
>>> --- commons/proper/scxml/branches/J6/pom.xml (original)
>>> +++ commons/proper/scxml/branches/J6/pom.xml Tue Apr 13 23:11:26 2010
>>> @@ -280,9 +280,9 @@
>>>       <plugin>
>>>         <groupId>org.apache.maven.plugins</groupId>
>>>         <artifactId>maven-changes-plugin</artifactId>
>>> -        <version>2.1</version>
>>> +        <version>2.0</version>
>> <snip/>
>>
>> Downgrade?
>
> Yes later versions of don't accept html markup - so this produces an
> empty report with 2.1 - see:
>
> http://commons.apache.org/scxml/changes-report.html
>
> Downgrading allowed the report to be produced OK. If you want to
> upgrade to a later version then you'll need to remove the markup from
> the changes.xml
>
<snip/>

Good to know the reason, I figured it had to do with maintaining a
functioning version of the plugin for us.

-Rahul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: changes-plugin version (was: svn commit: r933811)

Posted by Niall Pemberton <ni...@gmail.com>.
On Wed, Apr 14, 2010 at 12:18 AM, Rahul Akolkar <ra...@gmail.com> wrote:
> Thanks for doing this Niall. One comment below ...
>
> On Tue, Apr 13, 2010 at 7:11 PM,  <ni...@apache.org> wrote:
>> Author: niallp
>> Date: Tue Apr 13 23:11:26 2010
>> New Revision: 933811
>>
>> URL: http://svn.apache.org/viewvc?rev=933811&view=rev
>> Log:
>> Move/rename "xdocs" directory to standard m2 "src/site/xdoc"
>>
>> Added:
>>    commons/proper/scxml/branches/J6/src/changes/
>>    commons/proper/scxml/branches/J6/src/changes/changes.xml
>>      - copied unchanged from r933806, commons/proper/scxml/branches/J6/xdocs/changes.xml
>>    commons/proper/scxml/branches/J6/src/site/fml/
>>    commons/proper/scxml/branches/J6/src/site/fml/faq.fml
>>      - copied unchanged from r933806, commons/proper/scxml/branches/J6/xdocs/faq.fml
>>    commons/proper/scxml/branches/J6/src/site/xdoc/
>>      - copied from r933806, commons/proper/scxml/branches/J6/xdocs/
>> Removed:
>>    commons/proper/scxml/branches/J6/src/site/xdoc/changes.xml
>>    commons/proper/scxml/branches/J6/src/site/xdoc/faq.fml
>>    commons/proper/scxml/branches/J6/src/site/xdoc/images/
>>    commons/proper/scxml/branches/J6/src/site/xdoc/style/
>>    commons/proper/scxml/branches/J6/xdocs/
>> Modified:
>>    commons/proper/scxml/branches/J6/pom.xml
>>    commons/proper/scxml/branches/J6/src/assembly/src.xml
>>
>> Modified: commons/proper/scxml/branches/J6/pom.xml
>> URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/pom.xml?rev=933811&r1=933810&r2=933811&view=diff
>> ==============================================================================
>> --- commons/proper/scxml/branches/J6/pom.xml (original)
>> +++ commons/proper/scxml/branches/J6/pom.xml Tue Apr 13 23:11:26 2010
>> @@ -280,9 +280,9 @@
>>       <plugin>
>>         <groupId>org.apache.maven.plugins</groupId>
>>         <artifactId>maven-changes-plugin</artifactId>
>> -        <version>2.1</version>
>> +        <version>2.0</version>
> <snip/>
>
> Downgrade?

Yes later versions of don't accept html markup - so this produces an
empty report with 2.1 - see:

http://commons.apache.org/scxml/changes-report.html

Downgrading allowed the report to be produced OK. If you want to
upgrade to a later version then you'll need to remove the markup from
the changes.xml

Niall

> -Rahul
>
>
>>         <configuration>
>> -          <xmlPath>${basedir}/xdocs/changes.xml</xmlPath>
>> +          <xmlPath>${basedir}/src/changes/changes.xml</xmlPath>
>>           <issueLinkTemplate>%URL%/%ISSUE%</issueLinkTemplate>
>>         </configuration>
>>         <reportSets>
>>
>> Modified: commons/proper/scxml/branches/J6/src/assembly/src.xml
>> URL: http://svn.apache.org/viewvc/commons/proper/scxml/branches/J6/src/assembly/src.xml?rev=933811&r1=933810&r2=933811&view=diff
>> ==============================================================================
>> --- commons/proper/scxml/branches/J6/src/assembly/src.xml (original)
>> +++ commons/proper/scxml/branches/J6/src/assembly/src.xml Tue Apr 13 23:11:26 2010
>> @@ -27,11 +27,8 @@
>>                 <include>build.properties.sample</include>
>>                 <include>build.xml</include>
>>                 <include>LICENSE.txt</include>
>> -                <include>maven.xml</include>
>>                 <include>NOTICE.txt</include>
>>                 <include>pom.xml</include>
>> -                <include>project.properties</include>
>> -                <include>project.xml</include>
>>                 <include>RELEASE-NOTES.txt</include>
>>                 <include>scxml-asl-header.txt</include>
>>                 <include>scxml-checks.xml</include>
>> @@ -40,8 +37,5 @@
>>         <fileSet>
>>             <directory>src</directory>
>>         </fileSet>
>> -        <fileSet>
>> -            <directory>xdocs</directory>
>> -        </fileSet>
>>     </fileSets>
>>  </assembly>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org