You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2014/12/21 23:58:30 UTC
svn commit: r1647222 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java
Author: msahyoun
Date: Sun Dec 21 22:58:30 2014
New Revision: 1647222
URL: http://svn.apache.org/r1647222
Log:
PDFBOX-2516 don't cache default appearance string
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java?rev=1647222&r1=1647221&r2=1647222&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java Sun Dec 21 22:58:30 2014
@@ -50,7 +50,6 @@ public final class PDAcroForm implements
private COSDictionary acroForm;
private PDDocument document;
- private COSString defaultAppearance;
private Map<String,PDFieldTreeNode> fieldCache;
@@ -319,15 +318,7 @@ public final class PDAcroForm implements
*/
public COSString getDefaultAppearance()
{
- if (defaultAppearance == null)
- {
- COSBase daValue = getDictionary().getItem(COSName.DA);
- if (daValue != null)
- {
- defaultAppearance = (COSString)daValue;
- }
- }
- return defaultAppearance;
+ return (COSString) getDictionary().getItem(COSName.DA);
}
/**
@@ -339,12 +330,10 @@ public final class PDAcroForm implements
{
if (daValue != null)
{
- defaultAppearance = new COSString(daValue);
- getDictionary().setItem(COSName.DA, defaultAppearance);
+ getDictionary().setString(COSName.DA, daValue);
}
else
{
- defaultAppearance = null;
getDictionary().removeItem(COSName.DA);
}
}